From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8043 invoked by alias); 26 Jul 2004 23:55:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8031 invoked from network); 26 Jul 2004 23:55:41 -0000 Received: from unknown (HELO tisch.mail.mindspring.net) (207.69.200.157) by sourceware.org with SMTP; 26 Jul 2004 23:55:41 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by tisch.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BpFJk-0007bK-00; Mon, 26 Jul 2004 19:55:40 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 7D0AC4B102; Mon, 26 Jul 2004 19:55:50 -0400 (EDT) Date: Mon, 26 Jul 2004 23:55:00 -0000 From: Michael Chastain To: nickc@redhat.com Subject: Re: RFA/RFC: Change Sparc64 gdb.asm tests to use -gdwarf2 instead of -gstabs Cc: gdb-patches@sources.redhat.com Message-ID: <41059A05.nailMF911EDIR@mindspring.com> References: <41051014.nailLY111456S@mindspring.com> <41054231.7010006@redhat.com> In-Reply-To: <41054231.7010006@redhat.com> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00391.txt.bz2 All right! This patch is approved. > AFAIK there is no such bug report. Although there is a related one > about the generation of aligned and unaligned relocs for the Sparc. Then the test can continue to FAIL until someone files a bug report for it, or just fixes it, or maybe makes it UNSUPPORTED. That's okay. > OK I ran those tests, although I changed the flags to be "-gdwarf2" and > "-gstabs+". I also added "gdb.asm/asm-source.exp" to the command lines, > since I assumed that it was OK to just run the assembler tests. The > patch does not affect any other part of the GDB testsuite. Err right, my sample code was bad. Yeah, it's okay to just test asm-source.exp. > I ran the tests on an x86 native host and a Sparc64 native host, just to > make sure that the default selection code worked as well. There was > only one combination that produced any failures: > > Sparc64 native with -gstabs+ Beautiful, that's what I'm looking for. Now the next poor hacker who ventures into asm-source.exp will have something to read when they say "what is this ... let me check the mailing list archives ...". Michael C === 2004-07-26 Nick Clifton * gdb.asm/asm-source.exp (debug-flags): New variable. If a known good default value for a specific architecture is available then set it to that value. Otherwise default to the -gstabs switch. Remove the -g... switches from the asm-flags variable. Allow the target board info to override the value if it wants to. Pass the switch on the assembler command line.