From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19968 invoked by alias); 30 Jul 2004 11:55:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19952 invoked from network); 30 Jul 2004 11:55:50 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 30 Jul 2004 11:55:50 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6UBtoe1003357 for ; Fri, 30 Jul 2004 07:55:50 -0400 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6UBtna10288; Fri, 30 Jul 2004 07:55:49 -0400 Received: from [172.31.0.98] (vpnuser2.surrey.redhat.com [172.16.9.2]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id i6UBtkqp023004; Fri, 30 Jul 2004 12:55:47 +0100 Message-ID: <410A374A.9030008@redhat.com> Date: Fri, 30 Jul 2004 11:55:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 0.7 (X11/20040615) MIME-Version: 1.0 To: Mark Kettenis CC: mec.gnu@mindspring.com, gdb-patches@sources.redhat.com Subject: Re: RFA/RFC: Change Sparc64 gdb.asm tests to use -gdwarf2 instead of -gstabs References: <41051014 dot nailLY111456S at mindspring dot com> <41054231 dot 7010006 at redhat dot com> <41059A05.nailMF911EDIR@mindspring.com> <200407292303.i6TN30SB024149@elgar.kettenis.dyndns.org> In-Reply-To: <200407292303.i6TN30SB024149@elgar.kettenis.dyndns.org> Content-Type: multipart/mixed; boundary="------------080407050604080505010502" X-SW-Source: 2004-07/txt/msg00487.txt.bz2 This is a multi-part message in MIME format. --------------080407050604080505010502 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1096 Hi Mark, > Not all right! Nick, did you actually test this patch? The subject > of this thread is making sparc64 use -gdwarf2 instead of -gstabs, but > the patch changes it to -gdwarf-2 (note the extra dash). This isn't > accepted by gas on my OpenBSD/amd64 and OpenBSD/sparc64 systems, and > AFAICT it isn't accepted by the current gas from CVS either. I did test the patch - but unfortuntately I tested is against a GAS built from the CVS sources with a few, work-in-progress, modifications of my own applied - including one that supports -gdwarf-2 so that GAS would be consistent with the same switches supported by GCC. I am very sorry about this mistake - I should have used a pristeen version of GAS. I would like to apply the patch below to rectify this problem. Tested with an x86 native host and an sh-elf cross compiler. Is this OK ? Cheers Nick gdb/testsuite/ChangeLog 2004-07-30 Nick Clifton * gdb.asm/asm-source.exp: Fix typo in previous delta: gdwarf-2 -> gdwarf2. Move -gdwarf2 switch from asm-flags to debug-flags for m6811 and m6812. --------------080407050604080505010502 Content-Type: text/plain; name="asm-source.exp.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="asm-source.exp.patch" Content-length: 4504 Index: gdb/testsuite/gdb.asm/asm-source.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v retrieving revision 1.51 diff -c -3 -p -r1.51 asm-source.exp *** gdb/testsuite/gdb.asm/asm-source.exp 27 Jul 2004 09:28:42 -0000 1.51 --- gdb/testsuite/gdb.asm/asm-source.exp 30 Jul 2004 11:47:53 -0000 *************** switch -glob -- [istarget] { *** 43,49 **** # ??? Won't work with ecoff systems like Tru64, but then we also # don't have any other -g flag that creates mdebug output. set asm-flags "-no-mdebug -I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf-2" } "*arm-*-*" { set asm-arch arm --- 43,49 ---- # ??? Won't work with ecoff systems like Tru64, but then we also # don't have any other -g flag that creates mdebug output. set asm-flags "-no-mdebug -I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "*arm-*-*" { set asm-arch arm *************** switch -glob -- [istarget] { *** 66,72 **** "x86_64-*-*" { set asm-arch x86_64 set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf-2" } "i\[3456\]86-*-*" { set asm-arch i386 --- 66,72 ---- "x86_64-*-*" { set asm-arch x86_64 set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "i\[3456\]86-*-*" { set asm-arch i386 *************** switch -glob -- [istarget] { *** 77,87 **** } "m6811-*-*" { set asm-arch m68hc11 ! set asm-flags "-mshort-double -m68hc11 -gdwarf2 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}" } "m6812-*-*" { set asm-arch m68hc11 ! set asm-flags "-mshort-double -m68hc12 -gdwarf2 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}" } "mips*-*" { set asm-arch mips --- 77,89 ---- } "m6811-*-*" { set asm-arch m68hc11 ! set asm-flags "-mshort-double -m68hc11 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "m6812-*-*" { set asm-arch m68hc11 ! set asm-flags "-mshort-double -m68hc12 --no-warn -I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "mips*-*" { set asm-arch mips *************** switch -glob -- [istarget] { *** 92,98 **** "sh*-*-*" { set asm-arch sh set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf-2" } "sparc-*-*" { set asm-arch sparc --- 94,100 ---- "sh*-*-*" { set asm-arch sh set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "sparc-*-*" { set asm-arch sparc *************** switch -glob -- [istarget] { *** 100,111 **** "sparc64-*-*" { set asm-arch sparc64 set asm-flags "-xarch=v9 -I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf-2" } "xstormy16-*-*" { set asm-arch xstormy16 set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf-2" } "v850-*-*" { set asm-arch v850 --- 102,113 ---- "sparc64-*-*" { set asm-arch sparc64 set asm-flags "-xarch=v9 -I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "xstormy16-*-*" { set asm-arch xstormy16 set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "v850-*-*" { set asm-arch v850 *************** switch -glob -- [istarget] { *** 117,128 **** "ia64-*-*" { set asm-arch ia64 set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf-2" } "hppa*-linux-*" { set asm-arch pa set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf-2" } } --- 119,130 ---- "ia64-*-*" { set asm-arch ia64 set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } "hppa*-linux-*" { set asm-arch pa set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}" ! set debug-flags "-gdwarf2" } } --------------080407050604080505010502--