From: Andrew Cagney <cagney@gnu.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Daniel Jacobowitz <drow@false.org>,
Paul Hilfinger <hilfingr@gnat.com>,
jimb@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Introduce notion of "search name"
Date: Thu, 13 May 2004 14:29:00 -0000 [thread overview]
Message-ID: <40A38639.2010207@gnu.org> (raw)
In-Reply-To: <20040512165907.GF16083@gnat.com>
I.e., through out GDB there is the assumption that symtab internally
uses simple strings.
We shouldn't. Recalling that one of the underlying problems here was
the need to construct search names on the fly using more complext debug
info, we should instead have interfaces such as:
This is a worthy goal, but I see it as a goal separate from what the
patch is trying to achieve.
This is in part true. The mistake is to seperate cleanups (or
refactorings) from enhancements. Enhancement and fixes needs to go
hand-in-hand with a corresponding cleanups. If we don't do this, we
quickly find that those long over-due changes never occure.
> From what Paul is saying, the change you
> are objecting to introduces a check that is correct within the current
> implementation, and makes the kind of assumption that's already used
> everywhere. Why can't we use the current framework as is until the
> cleanup is done (BTW: who's going to do it, and when?). Admitedly, we
> have to document a temporary assumption, but I don't think this will
> affect the symbol interface cleanup you're suggesting all that much.
If this, as an implementation detail, were to be strictly hidden behind
the symtab interface, it wouldn't be a problem. Unfortunatly, as I
illustrated, the SYMBOL_*_NAME macros permieate GDB, so hand in hand
with this change, should be changes to screw down that aspect of the
symtab interface, and then have Ada use that.
enjoy,
Andew
next prev parent reply other threads:[~2004-05-13 14:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-03 19:15 Paul Hilfinger
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-05 3:59 ` Daniel Jacobowitz
2004-03-05 10:39 ` Paul Hilfinger
2004-03-19 0:09 ` Paul Hilfinger
2004-03-31 22:12 ` Daniel Jacobowitz
2004-04-01 14:53 ` Jim Blandy
2004-04-01 15:00 ` Daniel Jacobowitz
2004-04-01 15:21 ` Jim Blandy
2004-04-02 9:30 ` Paul Hilfinger
2004-04-02 22:27 ` Jim Blandy
2004-04-03 12:04 ` Paul Hilfinger
2004-04-06 14:37 ` Jim Blandy
2004-04-02 9:33 ` Paul Hilfinger
2004-04-02 8:29 ` Paul Hilfinger
2004-04-09 22:40 ` Daniel Jacobowitz
2004-04-12 8:22 ` Paul Hilfinger
2004-04-16 4:11 ` Jim Blandy
2004-04-29 10:37 ` Paul Hilfinger
[not found] ` <20040429211458.GB27523@nevyn.them.org>
[not found] ` <vt2n04umj8b.fsf@zenia.home>
[not found] ` <20040430084538.ECDE1F2E1C@nile.gnat.com>
[not found] ` <20040430134955.GA15786@nevyn.them.org>
2004-05-03 8:49 ` Paul Hilfinger
2004-05-11 19:48 ` Daniel Jacobowitz
2004-05-12 11:00 ` Paul Hilfinger
2004-05-12 13:27 ` Daniel Jacobowitz
2004-05-12 14:14 ` Andrew Cagney
2004-05-12 14:23 ` Daniel Jacobowitz
2004-05-12 15:11 ` Andrew Cagney
2004-05-12 16:59 ` Joel Brobecker
2004-05-13 14:29 ` Andrew Cagney [this message]
2004-05-13 9:30 ` Paul Hilfinger
2004-05-13 13:49 ` Daniel Jacobowitz
2004-05-18 21:59 ` Jim Blandy
2004-05-19 9:55 ` Paul Hilfinger
2004-05-19 13:00 ` Daniel Jacobowitz
2004-05-19 15:21 ` Andrew Cagney
2004-05-20 10:18 ` Abstracting "name" Paul Hilfinger
2004-05-21 19:10 ` Andrew Cagney
2004-05-21 20:01 ` Jim Blandy
2004-03-19 0:09 ` [RFA] Introduce notion of "search name" Paul Hilfinger
2004-03-19 0:09 ` David Carlton
2004-03-03 19:26 ` David Carlton
2004-03-19 0:09 ` Paul Hilfinger
2004-03-04 8:45 ` Paul Hilfinger
2004-03-30 9:37 Paul Hilfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A38639.2010207@gnu.org \
--to=cagney@gnu.org \
--cc=brobecker@gnat.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=hilfingr@gnat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox