From: Andrew Cagney <cagney@gnu.org>
To: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix gdb1476.exp on s390*
Date: Mon, 22 Mar 2004 17:22:00 -0000 [thread overview]
Message-ID: <405F20C5.7040700@gnu.org> (raw)
In-Reply-To: <200403171918.UAA09549@faui1d.informatik.uni-erlangen.de>
> Hello,
>
> this patch fixes the gdb.base/gdb1476.exp test case (backtrace from NULL
> function pointer call).
>
> When calling via an invalid function pointer, what we should do is simply
> unwind the PC from the return address register and continue. This is
> exactly what is done to unwind from a PLT stub as well, so the patch
> simply uses the PLT frame unwinder to handle this case as well.
While that might be true, I don't know that its the job of something
called "PLTSTUB". I can think of either:
- renaming pltstub to something that matches its new purpose (just "stub"?)
- using the default unwinder
thoughts?
Andrew
next prev parent reply other threads:[~2004-03-22 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-17 19:18 Ulrich Weigand
2004-03-19 0:09 ` Ulrich Weigand
2004-03-22 17:22 ` Andrew Cagney [this message]
2004-03-22 19:05 ` Ulrich Weigand
2004-03-22 21:58 ` Andrew Cagney
2004-03-22 22:20 ` Ulrich Weigand
2004-03-22 22:37 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405F20C5.7040700@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=weigand@i1.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox