From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14184 invoked by alias); 22 Mar 2004 17:22:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14177 invoked from network); 22 Mar 2004 17:22:16 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 22 Mar 2004 17:22:16 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 32BA32B92; Mon, 22 Mar 2004 12:22:13 -0500 (EST) Message-ID: <405F20C5.7040700@gnu.org> Date: Mon, 22 Mar 2004 17:22:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Ulrich Weigand Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix gdb1476.exp on s390* References: <200403171918.UAA09549@faui1d.informatik.uni-erlangen.de> In-Reply-To: <200403171918.UAA09549@faui1d.informatik.uni-erlangen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03/txt/msg00498.txt.bz2 > Hello, > > this patch fixes the gdb.base/gdb1476.exp test case (backtrace from NULL > function pointer call). > > When calling via an invalid function pointer, what we should do is simply > unwind the PC from the return address register and continue. This is > exactly what is done to unwind from a PLT stub as well, so the patch > simply uses the PLT frame unwinder to handle this case as well. While that might be true, I don't know that its the job of something called "PLTSTUB". I can think of either: - renaming pltstub to something that matches its new purpose (just "stub"?) - using the default unwinder thoughts? Andrew