Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hafiz Abid Qadeer <abid_qadeer@mentor.com>
To: <gcc-patches@gcc.gnu.org>
Cc: <gdb-patches@sourceware.org>, <binutils@sourceware.org>
Subject: Small typo in iconv.m4
Date: Tue, 06 Nov 2018 16:37:00 -0000	[thread overview]
Message-ID: <404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.

The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"

OK to commit the attached patch?

2018-11-06  Hafiz Abid Qadeer  <abidh@codesourcery.com>

	* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
	Append $INCICONV to it.
	* gcc/configure: Regenerate.
	* libcpp/configure: Likewise.
	* libstdc++-v3/configure: Likewise.
	* intl/configure: Likewise.

Thanks,
-- 
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery

[-- Attachment #2: iconv.patch --]
[-- Type: text/x-patch, Size: 445 bytes --]

diff --git a/config/iconv.m4 b/config/iconv.m4
index 5f9304a6ba..f1e54c5aed 100644
--- a/config/iconv.m4
+++ b/config/iconv.m4
@@ -73,7 +73,7 @@ AC_DEFUN([AM_ICONV_LINK],
     if test "$am_cv_func_iconv" != yes; then
       am_save_CPPFLAGS="$CPPFLAGS"
       am_save_LIBS="$LIBS"
-      CPPFLAGS="$LIBS $INCICONV"
+      CPPFLAGS="$CPPFLAGS $INCICONV"
       LIBS="$LIBS $LIBICONV"
       AC_TRY_LINK([#include <stdlib.h>
 #include <iconv.h>],

             reply	other threads:[~2018-11-06 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 16:37 Hafiz Abid Qadeer [this message]
2018-11-07 15:27 ` Simon Marchi
2018-11-07 22:41 ` Jeff Law
2018-11-09 17:57   ` Eric Gallager
2018-11-09 18:28     ` Jeff Law
2018-11-09 10:18 Hafiz Abid Qadeer
2018-11-09 12:59 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com \
    --to=abid_qadeer@mentor.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox