From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49389 invoked by alias); 6 Nov 2018 16:37:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49350 invoked by uid 89); 6 Nov 2018 16:37:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1123 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Nov 2018 16:37:30 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gK4M3-0004li-TO from abid_qadeer@mentor.com ; Tue, 06 Nov 2018 08:37:27 -0800 Received: from [137.202.204.206] (137.202.0.90) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 6 Nov 2018 16:37:24 +0000 From: Hafiz Abid Qadeer To: Subject: Small typo in iconv.m4 CC: , Message-ID: <404ed12c-79ec-7731-c013-47e7001e15a5@mentor.com> Date: Tue, 06 Nov 2018 16:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6D722577064905B9C70E4AFA" X-SW-Source: 2018-11/txt/msg00060.txt.bz2 --------------6D722577064905B9C70E4AFA Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-length: 705 Hi All, I was investigating a character set related problem with windows hosted GDB and I tracked it down to a typo in iconv.m4. This typo caused libiconv detection to fail and related support was not built into gdb. The problem is with the following line. CPPFLAGS="$LIBS $INCICONV" which should have been CPPFLAGS="$CPPFLAGS $INCICONV" OK to commit the attached patch? 2018-11-06 Hafiz Abid Qadeer * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS. Append $INCICONV to it. * gcc/configure: Regenerate. * libcpp/configure: Likewise. * libstdc++-v3/configure: Likewise. * intl/configure: Likewise. Thanks, -- Hafiz Abid Qadeer Mentor Embedded/CodeSourcery --------------6D722577064905B9C70E4AFA Content-Type: text/x-patch; name="iconv.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="iconv.patch" Content-length: 445 diff --git a/config/iconv.m4 b/config/iconv.m4 index 5f9304a6ba..f1e54c5aed 100644 --- a/config/iconv.m4 +++ b/config/iconv.m4 @@ -73,7 +73,7 @@ AC_DEFUN([AM_ICONV_LINK], if test "$am_cv_func_iconv" != yes; then am_save_CPPFLAGS="$CPPFLAGS" am_save_LIBS="$LIBS" - CPPFLAGS="$LIBS $INCICONV" + CPPFLAGS="$CPPFLAGS $INCICONV" LIBS="$LIBS $LIBICONV" AC_TRY_LINK([#include #include ], --------------6D722577064905B9C70E4AFA--