From: Nick Clifton <nickc@redhat.com>
To: Hafiz Abid Qadeer <abid_qadeer@mentor.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
binutils@sourceware.org
Subject: Re: Small typo in iconv.m4
Date: Fri, 09 Nov 2018 12:59:00 -0000 [thread overview]
Message-ID: <471f1420-6f3b-0146-02aa-61f7b99c330b@redhat.com> (raw)
In-Reply-To: <1a59139c-804c-2cc5-821b-edabd3ba9f84@mentor.com>
Hi Hafiz,
> Hi All,
> Attached config/ patch was approved and committed in gcc repo. Ok to
> commit it in the binutils-gdb repo?
>
> 2018-11-09 Hafiz Abid Qadeer <abidh@codesourcery.com>
>
> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
> Append $INCICONV to it.
> * gdb/configure: Regenerate.
> * binutils/configure: Likewise.
> * intl/configure: Likewise.
Approved, please apply. I should note however that the changelog
entry probably should be split up and added to the respective
subdirectories ChangeLog files. In particular I was confused because
I could not find a mention on the change in gcc's config/ChangeLog
file, and was rather surprised when I found it in the top level
ChangeLog file instead.
Cheers
Nick
next prev parent reply other threads:[~2018-11-09 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 10:18 Hafiz Abid Qadeer
2018-11-09 12:59 ` Nick Clifton [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-06 16:37 Hafiz Abid Qadeer
2018-11-07 15:27 ` Simon Marchi
2018-11-07 22:41 ` Jeff Law
2018-11-09 17:57 ` Eric Gallager
2018-11-09 18:28 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471f1420-6f3b-0146-02aa-61f7b99c330b@redhat.com \
--to=nickc@redhat.com \
--cc=abid_qadeer@mentor.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox