From: Andrew Cagney <cagney@gnu.org>
To: Mark Kettenis <kettenis@chello.nl>, eliz@elta.co.il
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Partial infcmd.c cleanup
Date: Mon, 26 Jan 2004 16:55:00 -0000 [thread overview]
Message-ID: <4015468C.6070007@gnu.org> (raw)
In-Reply-To: <200401261155.i0QBt5uJ026463@elgar.kettenis.dyndns.org>
> But I didn't. It already was static, since the earlier on in the file
> we have the prototype:
>
> static void finish_command_continuation (struct continuation_arg *);
>
> I should have mentioned it in the ChangeLog.
Sigh, "GDB's K&R herritage hits, you start feeling old" :-) The code style:
static void func (args);
... big big gap ...
void
func (args)
{
..
}
dates back to K&R C days where we ended up with:
static void func PARAMS ((type arg, ...));
... big big gap ...
void
func (arg)
type arg;
{
}
to ensure that prototypes were present. With the switch to ISO-C those
declarations became entirely reundant (except when a forward declaration
is explicitly needed) and have since been slowly disappearing.
enjoy,
Andrew
prev parent reply other threads:[~2004-01-26 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-25 17:32 Mark Kettenis
2004-01-26 6:18 ` Eli Zaretskii
2004-01-26 11:55 ` Mark Kettenis
2004-01-26 16:55 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4015468C.6070007@gnu.org \
--to=cagney@gnu.org \
--cc=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox