From: Mark Kettenis <kettenis@chello.nl>
To: eliz@elta.co.il
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Partial infcmd.c cleanup
Date: Mon, 26 Jan 2004 11:55:00 -0000 [thread overview]
Message-ID: <200401261155.i0QBt5uJ026463@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <ubror2pwa.fsf@elta.co.il> (message from Eli Zaretskii on 26 Jan 2004 08:19:17 +0200)
Date: 26 Jan 2004 08:19:17 +0200
From: Eli Zaretskii <eliz@elta.co.il>
> Date: Sun, 25 Jan 2004 18:32:48 +0100 (CET)
> From: Mark Kettenis <kettenis@chello.nl>
>
> Since I'll be changing this bit of code I though I'd give it a cleanup
> first. Mostly wrapping long lines and adding some missing whitespace.
>
> Committed as obvious,
I think changing finish_command_continuation from a void function into
a static void function does not really qualify as obvious. I'm
talking about this part of the patch:
But I didn't. It already was static, since the earlier on in the file
we have the prototype:
static void finish_command_continuation (struct continuation_arg *);
I should have mentioned it in the ChangeLog.
Mark
next prev parent reply other threads:[~2004-01-26 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-25 17:32 Mark Kettenis
2004-01-26 6:18 ` Eli Zaretskii
2004-01-26 11:55 ` Mark Kettenis [this message]
2004-01-26 16:55 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401261155.i0QBt5uJ026463@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox