From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24149 invoked by alias); 26 Jan 2004 16:55:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24130 invoked from network); 26 Jan 2004 16:55:41 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 26 Jan 2004 16:55:41 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 94D882B8F; Mon, 26 Jan 2004 11:55:40 -0500 (EST) Message-ID: <4015468C.6070007@gnu.org> Date: Mon, 26 Jan 2004 16:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Mark Kettenis , eliz@elta.co.il Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Partial infcmd.c cleanup References: <200401251732.i0PHWmRq007000@elgar.kettenis.dyndns.org> <200401261155.i0QBt5uJ026463@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00669.txt.bz2 > But I didn't. It already was static, since the earlier on in the file > we have the prototype: > > static void finish_command_continuation (struct continuation_arg *); > > I should have mentioned it in the ChangeLog. Sigh, "GDB's K&R herritage hits, you start feeling old" :-) The code style: static void func (args); ... big big gap ... void func (args) { .. } dates back to K&R C days where we ended up with: static void func PARAMS ((type arg, ...)); ... big big gap ... void func (arg) type arg; { } to ensure that prototypes were present. With the switch to ISO-C those declarations became entirely reundant (except when a forward declaration is explicitly needed) and have since been slowly disappearing. enjoy, Andrew