Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: "J. Johnston" <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFA]: error_silent for use in pending breakpoint support
Date: Mon, 19 Jan 2004 23:10:00 -0000	[thread overview]
Message-ID: <400C63E2.1080302@gnu.org> (raw)
In-Reply-To: <40072573.8020807@redhat.com>


> 
> Ok, patch revised.
> 
> I chose to add a new version of catch_exceptions() called catch_exceptions_with_msg() which saves a copy of the error message (if an error occurs) for the caller to manually output if desired.  The copy needs to be freed by the caller once the message is no longer needed.
> 
> I removed error_last_output() and created a new function error_output_message() which takes pre_print text plus a message and outputs to gdb_stderr.
> 
> Any other problems or ok to commit? 

Much nicer - that nasty message buffer is better confied to top.c - 
thank.  Just suggest more commentary here:
> -	  throw_exception (RETURN_ERROR);
> +	  error_silent ("No source file named %s.", copy);
before committing (elena's already oked it from memory).

tks.
Andrew



  reply	other threads:[~2004-01-19 23:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-18 21:42 Jeff Johnston
2004-01-09 18:55 ` J. Johnston
2004-01-11 20:46 ` Andrew Cagney
2004-01-15 23:42   ` J. Johnston
2004-01-19 23:10     ` Andrew Cagney [this message]
2004-01-20  2:05       ` J. Johnston
2004-01-12 15:27 ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=400C63E2.1080302@gnu.org \
    --to=cagney@gnu.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox