From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11487 invoked by alias); 19 Jan 2004 23:10:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11471 invoked from network); 19 Jan 2004 23:10:28 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 19 Jan 2004 23:10:28 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id AAF5E2B8F; Mon, 19 Jan 2004 18:10:26 -0500 (EST) Message-ID: <400C63E2.1080302@gnu.org> Date: Mon, 19 Jan 2004 23:10:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: "J. Johnston" Cc: gdb-patches@sources.redhat.com, Elena Zannoni Subject: Re: [RFA]: error_silent for use in pending breakpoint support References: <3FE21F2B.3030104@redhat.com> <4001B608.2010607@gnu.org> <40072573.8020807@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00535.txt.bz2 > > Ok, patch revised. > > I chose to add a new version of catch_exceptions() called catch_exceptions_with_msg() which saves a copy of the error message (if an error occurs) for the caller to manually output if desired. The copy needs to be freed by the caller once the message is no longer needed. > > I removed error_last_output() and created a new function error_output_message() which takes pre_print text plus a message and outputs to gdb_stderr. > > Any other problems or ok to commit? Much nicer - that nasty message buffer is better confied to top.c - thank. Just suggest more commentary here: > - throw_exception (RETURN_ERROR); > + error_silent ("No source file named %s.", copy); before committing (elena's already oked it from memory). tks. Andrew