Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFA]: error_silent for use in pending breakpoint support
Date: Sun, 11 Jan 2004 20:46:00 -0000	[thread overview]
Message-ID: <4001B608.2010607@gnu.org> (raw)
In-Reply-To: <3FE21F2B.3030104@redhat.com>

> To properly support pending breakpoints, gdb needs to be able to suppress the "not found" messages at will, but it also needs to sometimes issue these messages and determine the cause of the error was a "not found" event.
> 
> To handle the problem, I propose two new useful functions in utils.c.  The first is error_silent() which works just like error(), only it does not issue the error message.  Like error(), it stores the error message in gdb_lasterr.  This leads to the other new function: error_last_output() which is used to output the last error message.
> 
> This allows the pending breakpoint support to issue the error message when the user is doing the initial break command and to suppress it when shared libraries are being loaded or a pending breakpoint is reenabled.

(I noticed this mentioned linespec so left it, it's really more of a 
change to utils though).

What does the stack look like at the point where error_silent is being 
called?

I'm thinking that something more like:

	catch_exception_error (....., &error_mesg);
with
	throw_error (message, ...) // silent

or
	catch_exception_silently (..., &error_mesg);
with
	error (message, ...)

would be better.  With that it should be possible to avoid the stateful 
error_last_output interface.   I think this would also be better long 
term as it should lend itself to the recursive case (where an error is 
being propogated up the stack).


Andrew



  parent reply	other threads:[~2004-01-11 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-18 21:42 Jeff Johnston
2004-01-09 18:55 ` J. Johnston
2004-01-11 20:46 ` Andrew Cagney [this message]
2004-01-15 23:42   ` J. Johnston
2004-01-19 23:10     ` Andrew Cagney
2004-01-20  2:05       ` J. Johnston
2004-01-12 15:27 ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4001B608.2010607@gnu.org \
    --to=cagney@gnu.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox