Re: Resend: [RFA] Fix problem with i386 watchpoints after restarting

[Pierre Muller <muller@cerbere.u-strasbg.fr>]

At 12:16 13/06/2002 , Mark Kettenis a écrit:
>Sorry, I somehow missed your earlier message.  This seems to me as an
>acceptable way to solve the problem (although I still think there is
>something wrong with GDB's mechanism of removing hardware breakpoints.
>But: could you add the reason why this is needed to the comment.
>Minor nit: Please end your sentences with a '.' and put two spaces
>after it.
OK, I slightly modifed the patch
by adding a comment to i386-nat.c 
and correcting the comment in the nm-i386.h file.

Can I check this in?

2002-06-17 Pierre Muller  <muller@ics.u-strasbg.fr>

         * i386-nat.c (child_post_startup_inferior): New function
         calling i386_cleanup_dregs if
         I386_USE_GENERIC_WATCHPOINTS is defined.
         * config/i386/nm-i386.h: define CHILD_POST_STARTUP_INFERIOR
         conditional to acknowledge that i386-nat.c has its
         own child_post_startup_inferior function.

Index: i386-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/i386-nat.c,v
retrieving revision 1.4
diff -r1.4 i386-nat.c
232a233,240
 > /* Reset all debug registers at each new startup
 >    to avoid missing watchpoints after restart.  */
 > void
 > child_post_startup_inferior (ptid_t ptid)
 > {
 >   i386_cleanup_dregs ();
 > }
 > 
Index: config/i386/nm-i386.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nm-i386.h,v
retrieving revision 1.2
diff -r1.2 nm-i386.h
117a118,121
 > /* child_post_startup_inferior used to
 >    reset all debug registers by calling i386_cleanup_dregs ().  */ 
 > #define CHILD_POST_STARTUP_INFERIOR
 > 



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99