From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28701 invoked by alias); 17 Jun 2002 13:38:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28651 invoked from network); 17 Jun 2002 13:38:50 -0000 Received: from unknown (HELO isis.u-strasbg.fr) (130.79.200.1) by sources.redhat.com with SMTP; 17 Jun 2002 13:38:50 -0000 Received: from cerbere.u-strasbg.fr (cerbere.u-strasbg.fr [130.79.112.7]) by isis.u-strasbg.fr (8.12.3/jtpda-5.4) with ESMTP id g5HDcmpU080522 ; Mon, 17 Jun 2002 15:38:48 +0200 (CEST) Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id PAA22655; Mon, 17 Jun 2002 15:38:32 +0200 Message-Id: <4.2.0.58.20020617153258.00a45d18@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Mon, 17 Jun 2002 06:38:00 -0000 To: Mark Kettenis From: Pierre Muller Subject: Re: Resend: [RFA] Fix problem with i386 watchpoints after restarting Cc: gdb-patches@sources.redhat.com In-Reply-To: <200206131016.g5DAGcf00647@elgar.kettenis.dyndns.org> References: <4.2.0.58.20020613091046.01957c70@ics.u-strasbg.fr> <4.2.0.58.20020613091046.01957c70@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-SW-Source: 2002-06/txt/msg00298.txt.bz2 At 12:16 13/06/2002 , Mark Kettenis a écrit: >Sorry, I somehow missed your earlier message. This seems to me as an >acceptable way to solve the problem (although I still think there is >something wrong with GDB's mechanism of removing hardware breakpoints. >But: could you add the reason why this is needed to the comment. >Minor nit: Please end your sentences with a '.' and put two spaces >after it. OK, I slightly modifed the patch by adding a comment to i386-nat.c and correcting the comment in the nm-i386.h file. Can I check this in? 2002-06-17 Pierre Muller * i386-nat.c (child_post_startup_inferior): New function calling i386_cleanup_dregs if I386_USE_GENERIC_WATCHPOINTS is defined. * config/i386/nm-i386.h: define CHILD_POST_STARTUP_INFERIOR conditional to acknowledge that i386-nat.c has its own child_post_startup_inferior function. Index: i386-nat.c =================================================================== RCS file: /cvs/src/src/gdb/i386-nat.c,v retrieving revision 1.4 diff -r1.4 i386-nat.c 232a233,240 > /* Reset all debug registers at each new startup > to avoid missing watchpoints after restart. */ > void > child_post_startup_inferior (ptid_t ptid) > { > i386_cleanup_dregs (); > } > Index: config/i386/nm-i386.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/nm-i386.h,v retrieving revision 1.2 diff -r1.2 nm-i386.h 117a118,121 > /* child_post_startup_inferior used to > reset all debug registers by calling i386_cleanup_dregs (). */ > #define CHILD_POST_STARTUP_INFERIOR > Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99