Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pierre Muller <muller@cerbere.u-strasbg.fr>
To: gdb-patches@sources.redhat.com
Subject: [RFA] honor new-console and new-group in win32-nat.c
Date: Fri, 22 Feb 2002 00:49:00 -0000	[thread overview]
Message-ID: <4.2.0.58.20020222094006.014b2518@ics.u-strasbg.fr> (raw)


Since the shell patch in win32-nat.c,
the new-group and new-console commands are igonred.

This is due to a small mistake in  child_create_inferior.

The following patch fixed this.
If you use new-console, this patch will also expose
another problem (not fixed here), which is that the
shell is not allowed to exit after exit of the debuggee.

Christopher,  shouldn't you set usesshell to 0
already so that other people trying to use the cygwin native 
from CVS will be able to use it normally until you
fix the other problems relative to shell usage.


2002-02-22  Pierre Muller  <muller@ics.u-strasbg.fr>

	* win32-nat.c (child_create_inferior): Fix create flags setting bug.



$ cvs diff -up win32-nat.c
Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.55
diff -u -p -r1.55 win32-nat.c
--- win32-nat.c 2002/02/22 01:35:59     1.55
+++ win32-nat.c 2002/02/22 08:42:16
@@ -1478,7 +1478,7 @@ child_create_inferior (char *exec_file,

    if (!useshell || !shell[0])
      {
-      flags = DEBUG_ONLY_THIS_PROCESS;
+      flags |= DEBUG_ONLY_THIS_PROCESS;
        cygwin_conv_to_win32_path (exec_file, real_path);
        toexec = real_path;
      }
@@ -1488,7 +1488,7 @@ child_create_inferior (char *exec_file,
        sprintf (newallargs, " -c 'exec %s %s'", exec_file, allargs);
        allargs = newallargs;
        toexec = shell;
-      flags = DEBUG_PROCESS;
+      flags |= DEBUG_PROCESS;
      }

    args = alloca (strlen (toexec) + strlen (allargs) + 2);



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99


             reply	other threads:[~2002-02-22  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-22  0:49 Pierre Muller [this message]
2002-02-22  8:25 ` Christopher Faylor
2002-02-22  8:28   ` Christopher Faylor
2002-02-22  9:05     ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4.2.0.58.20020222094006.014b2518@ics.u-strasbg.fr \
    --to=muller@cerbere.u-strasbg.fr \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox