From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] honor new-console and new-group in win32-nat.c
Date: Fri, 22 Feb 2002 08:28:00 -0000 [thread overview]
Message-ID: <20020222162808.GA15597@redhat.com> (raw)
In-Reply-To: <20020222162541.GI15032@redhat.com>
On Fri, Feb 22, 2002 at 11:25:41AM -0500, Christopher Faylor wrote:
>On Fri, Feb 22, 2002 at 09:48:41AM +0100, Pierre Muller wrote:
>>
>>Since the shell patch in win32-nat.c,
>>the new-group and new-console commands are igonred.
>>
>>This is due to a small mistake in child_create_inferior.
>>
>>The following patch fixed this.
>>If you use new-console, this patch will also expose
>>another problem (not fixed here), which is that the
>>shell is not allowed to exit after exit of the debuggee.
>>
>>Christopher, shouldn't you set usesshell to 0
>>already so that other people trying to use the cygwin native
>>from CVS will be able to use it normally until you
>>fix the other problems relative to shell usage.
>>
>>
>>2002-02-22 Pierre Muller <muller@ics.u-strasbg.fr>
>>
>> * win32-nat.c (child_create_inferior): Fix create flags setting bug.
>
>Ok. Please check in.
Actually. Wait. There's a better way to do this. Sorry.
Just get rid of the flags = 0 and move the useshell stuff prior to
the flags |=. That's what I'd intended to do but muffed the placement
of the useshell conditionals.
cgf
next prev parent reply other threads:[~2002-02-22 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-22 0:49 Pierre Muller
2002-02-22 8:25 ` Christopher Faylor
2002-02-22 8:28 ` Christopher Faylor [this message]
2002-02-22 9:05 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020222162808.GA15597@redhat.com \
--to=cgf@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox