From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7706 invoked by alias); 22 Feb 2002 16:28:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7597 invoked from network); 22 Feb 2002 16:28:02 -0000 Received: from unknown (HELO lacrosse.corp.redhat.com) (66.187.233.200) by sources.redhat.com with SMTP; 22 Feb 2002 16:28:02 -0000 Received: from cgf.cipe.redhat.com (cgf.cipe.redhat.com [10.0.1.172]) by lacrosse.corp.redhat.com (8.11.6/8.9.3) with ESMTP id g1MGS1s02175 for ; Fri, 22 Feb 2002 11:28:01 -0500 Received: (from cgf@localhost) by cgf.cipe.redhat.com (8.11.6/8.8.7) id g1MGS8D15613 for gdb-patches@sources.redhat.com; Fri, 22 Feb 2002 11:28:08 -0500 Date: Fri, 22 Feb 2002 08:28:00 -0000 From: Christopher Faylor To: gdb-patches@sources.redhat.com Subject: Re: [RFA] honor new-console and new-group in win32-nat.c Message-ID: <20020222162808.GA15597@redhat.com> Mail-Followup-To: gdb-patches@sources.redhat.com References: <4.2.0.58.20020222094006.014b2518@ics.u-strasbg.fr> <20020222162541.GI15032@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020222162541.GI15032@redhat.com> User-Agent: Mutt/1.3.23.1i X-SW-Source: 2002-02/txt/msg00620.txt.bz2 On Fri, Feb 22, 2002 at 11:25:41AM -0500, Christopher Faylor wrote: >On Fri, Feb 22, 2002 at 09:48:41AM +0100, Pierre Muller wrote: >> >>Since the shell patch in win32-nat.c, >>the new-group and new-console commands are igonred. >> >>This is due to a small mistake in child_create_inferior. >> >>The following patch fixed this. >>If you use new-console, this patch will also expose >>another problem (not fixed here), which is that the >>shell is not allowed to exit after exit of the debuggee. >> >>Christopher, shouldn't you set usesshell to 0 >>already so that other people trying to use the cygwin native >>from CVS will be able to use it normally until you >>fix the other problems relative to shell usage. >> >> >>2002-02-22 Pierre Muller >> >> * win32-nat.c (child_create_inferior): Fix create flags setting bug. > >Ok. Please check in. Actually. Wait. There's a better way to do this. Sorry. Just get rid of the flags = 0 and move the useshell stuff prior to the flags |=. That's what I'd intended to do but muffed the placement of the useshell conditionals. cgf