From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 921 invoked by alias); 22 Feb 2002 08:49:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 705 invoked from network); 22 Feb 2002 08:49:22 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.7) by sources.redhat.com with SMTP; 22 Feb 2002 08:49:22 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id JAA20804 for ; Fri, 22 Feb 2002 09:49:20 +0100 Message-Id: <4.2.0.58.20020222094006.014b2518@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr X-Mailer: QUALCOMM Windows Eudora Pro Version 4.2.0.58 Date: Fri, 22 Feb 2002 00:49:00 -0000 To: gdb-patches@sources.redhat.com From: Pierre Muller Subject: [RFA] honor new-console and new-group in win32-nat.c Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2002-02/txt/msg00616.txt.bz2 Since the shell patch in win32-nat.c, the new-group and new-console commands are igonred. This is due to a small mistake in child_create_inferior. The following patch fixed this. If you use new-console, this patch will also expose another problem (not fixed here), which is that the shell is not allowed to exit after exit of the debuggee. Christopher, shouldn't you set usesshell to 0 already so that other people trying to use the cygwin native from CVS will be able to use it normally until you fix the other problems relative to shell usage. 2002-02-22 Pierre Muller * win32-nat.c (child_create_inferior): Fix create flags setting bug. $ cvs diff -up win32-nat.c Index: win32-nat.c =================================================================== RCS file: /cvs/src/src/gdb/win32-nat.c,v retrieving revision 1.55 diff -u -p -r1.55 win32-nat.c --- win32-nat.c 2002/02/22 01:35:59 1.55 +++ win32-nat.c 2002/02/22 08:42:16 @@ -1478,7 +1478,7 @@ child_create_inferior (char *exec_file, if (!useshell || !shell[0]) { - flags = DEBUG_ONLY_THIS_PROCESS; + flags |= DEBUG_ONLY_THIS_PROCESS; cygwin_conv_to_win32_path (exec_file, real_path); toexec = real_path; } @@ -1488,7 +1488,7 @@ child_create_inferior (char *exec_file, sprintf (newallargs, " -c 'exec %s %s'", exec_file, allargs); allargs = newallargs; toexec = shell; - flags = DEBUG_PROCESS; + flags |= DEBUG_PROCESS; } args = alloca (strlen (toexec) + strlen (allargs) + 2); Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99