Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pierre Muller <muller@cerbere.u-strasbg.fr>
To: gdb-patches@sources.redhat.com
Subject: [RFA] remove unwanted output in breakpoint_re_set_one
Date: Mon, 14 Jan 2002 03:37:00 -0000	[thread overview]
Message-ID: <4.2.0.58.20020114121954.00acc5b8@ics.u-strasbg.fr> (raw)


The patch below finally removes the 
lot of "Watchpoint XXXX" or "Hardware watchpoint XXX" output that can be seen
both for normal and hardware watchpoints 
at each loadnig of a shared library (or each DLL
in win32 target.

This problem was first reported in my first proposal
about win32 hardware watchpoint support for win32 target,
http://sources.redhat.com/ml/gdb-patches/2001-11/msg00537.html
and caused some confusion, as this was first seen as a
problem with my implementation.
But this was a quite general error present for other targets, like i386 linux,
see my post-scriptum in 
http://sources.redhat.com/ml/gdb-patches/2001-12/msg00030.html

The call to mention at that location in breakpoint_re_set_one 
seems completely unnecessary.

2002-01-14  Pierre Muller  <muller@ics.u-strasbg.fr>

	* breakpoint.c (breakpoint_re_set_one): Remove call to mention
	for watchpoints to avoid unnecessary output 
	when dynamic libraries are loaded.





Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.57
diff -u -p -r1.57 breakpoint.c
--- breakpoint.c        2001/11/11 16:39:59     1.57
+++ breakpoint.c        2002/01/14 11:19:54
@@ -7139,8 +7139,6 @@ breakpoint_re_set_one (PTR bint)
             xfree (b->cond);
           b->cond = parse_exp_1 (&s, (struct block *) 0, 0);
         }
-      if (b->enable_state == bp_enabled)
-       mention (b);
        value_free_to_mark (mark);
        break;
      case bp_catch_catch:



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99


             reply	other threads:[~2002-01-14 11:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-14  3:37 Pierre Muller [this message]
2002-01-14  4:43 ` Eli Zaretskii
2002-01-14 11:11   ` muller
2002-01-14 23:44     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4.2.0.58.20020114121954.00acc5b8@ics.u-strasbg.fr \
    --to=muller@cerbere.u-strasbg.fr \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox