Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: muller@cerbere.u-strasbg.fr
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] remove unwanted output in breakpoint_re_set_one
Date: Mon, 14 Jan 2002 11:11:00 -0000	[thread overview]
Message-ID: <3.0.6.32.20020114202242.0099adc0@ics.u-strasbg.fr> (raw)
In-Reply-To: <Pine.SUN.3.91.1020114143945.16401A@is>

At 14:42 14/01/02 +0200, Eli Zaretskii wrote:
>
>On Mon, 14 Jan 2002, Pierre Muller wrote:
>
>> 2002-01-14  Pierre Muller  <muller@ics.u-strasbg.fr>
>> 
>> 	* breakpoint.c (breakpoint_re_set_one): Remove call to mention
>> 	for watchpoints to avoid unnecessary output 
>> 	when dynamic libraries are loaded.
>
>This, of course, begs the question: why was the call to `mention' in 
>breakpoint_re_set_one in the first place?  Is this function called only 
>when a dynamic library was loaded?  If not, we might be shooting 
>ourselves in the foot.  Even if it is only called when a dynamic library 
>was loaded, the question why the message was put there still remains.

If you look above in the same function you will see that
mention is called for breakpoints, but only if the breakpoint
address changed.

So it should probably be the same here, but
can a shared lib loading change the watched addresses
needed to watch a given expression? 
I suppose that a correct implementation would 
just call mention if the watched address area are changed,
but I have no idea how that can be done, and I am not
enough interested in this to invest time to try to find out
how that could be accomplished.




  reply	other threads:[~2002-01-14 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-14  3:37 Pierre Muller
2002-01-14  4:43 ` Eli Zaretskii
2002-01-14 11:11   ` muller [this message]
2002-01-14 23:44     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3.0.6.32.20020114202242.0099adc0@ics.u-strasbg.fr \
    --to=muller@cerbere.u-strasbg.fr \
    --cc=eliz@is.elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox