From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30041 invoked by alias); 14 Jan 2002 19:11:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29987 invoked from network); 14 Jan 2002 19:10:58 -0000 Received: from unknown (HELO factorix.sdv.fr) (194.206.196.2) by sources.redhat.com with SMTP; 14 Jan 2002 19:10:58 -0000 Received: from ordimaison (ip-76-192.evc.net [212.95.76.192]) by factorix.sdv.fr (8.11.4/8.11.4) with SMTP id g0EJ4bR15398; Mon, 14 Jan 2002 20:04:38 +0100 Message-Id: <3.0.6.32.20020114202242.0099adc0@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr X-Mailer: QUALCOMM Windows Eudora Light Version 3.0.6 (32) Date: Mon, 14 Jan 2002 11:11:00 -0000 To: Eli Zaretskii From: muller@cerbere.u-strasbg.fr Subject: Re: [RFA] remove unwanted output in breakpoint_re_set_one Cc: gdb-patches@sources.redhat.com In-Reply-To: References: <4.2.0.58.20020114121954.00acc5b8@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2002-01/txt/msg00393.txt.bz2 At 14:42 14/01/02 +0200, Eli Zaretskii wrote: > >On Mon, 14 Jan 2002, Pierre Muller wrote: > >> 2002-01-14 Pierre Muller >> >> * breakpoint.c (breakpoint_re_set_one): Remove call to mention >> for watchpoints to avoid unnecessary output >> when dynamic libraries are loaded. > >This, of course, begs the question: why was the call to `mention' in >breakpoint_re_set_one in the first place? Is this function called only >when a dynamic library was loaded? If not, we might be shooting >ourselves in the foot. Even if it is only called when a dynamic library >was loaded, the question why the message was put there still remains. If you look above in the same function you will see that mention is called for breakpoints, but only if the breakpoint address changed. So it should probably be the same here, but can a shared lib loading change the watched addresses needed to watch a given expression? I suppose that a correct implementation would just call mention if the watched address area are changed, but I have no idea how that can be done, and I am not enough interested in this to invest time to try to find out how that could be accomplished.