From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6263 invoked by alias); 14 Jan 2002 11:37:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6222 invoked from network); 14 Jan 2002 11:37:20 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.7) by sources.redhat.com with SMTP; 14 Jan 2002 11:37:20 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id MAA11377 for ; Mon, 14 Jan 2002 12:37:16 +0100 Message-Id: <4.2.0.58.20020114121954.00acc5b8@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr X-Mailer: QUALCOMM Windows Eudora Pro Version 4.2.0.58 Date: Mon, 14 Jan 2002 03:37:00 -0000 To: gdb-patches@sources.redhat.com From: Pierre Muller Subject: [RFA] remove unwanted output in breakpoint_re_set_one Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2002-01/txt/msg00386.txt.bz2 The patch below finally removes the lot of "Watchpoint XXXX" or "Hardware watchpoint XXX" output that can be seen both for normal and hardware watchpoints at each loadnig of a shared library (or each DLL in win32 target. This problem was first reported in my first proposal about win32 hardware watchpoint support for win32 target, http://sources.redhat.com/ml/gdb-patches/2001-11/msg00537.html and caused some confusion, as this was first seen as a problem with my implementation. But this was a quite general error present for other targets, like i386 linux, see my post-scriptum in http://sources.redhat.com/ml/gdb-patches/2001-12/msg00030.html The call to mention at that location in breakpoint_re_set_one seems completely unnecessary. 2002-01-14 Pierre Muller * breakpoint.c (breakpoint_re_set_one): Remove call to mention for watchpoints to avoid unnecessary output when dynamic libraries are loaded. Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.57 diff -u -p -r1.57 breakpoint.c --- breakpoint.c 2001/11/11 16:39:59 1.57 +++ breakpoint.c 2002/01/14 11:19:54 @@ -7139,8 +7139,6 @@ breakpoint_re_set_one (PTR bint) xfree (b->cond); b->cond = parse_exp_1 (&s, (struct block *) 0, 0); } - if (b->enable_state == bp_enabled) - mention (b); value_free_to_mark (mark); break; case bp_catch_catch: Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99