Re: [PATCH v2 2/4] gdb/aarch64: Test record/replay support for CSSC

[Guinevere Larsen <guinevere@redhat.com>]

On 5/15/26 12:50 AM, Thiago Jung Bauermann wrote:
> <Ezra.Sitorus@arm.com> writes:
>
>> From: Ezra Sitorus <ezra.sitorus@arm.com>
>>
>> GDB can handle AArch64's CSSC instructions but there were no tests
>> ensuring that and ensuring no regressions would creep in. This commit
>> adds some tests for these instructions. This was tested on
>> aarch64-none-linux-gnu on QEMU with CSSC support.
>> ---
>>   gdb/testsuite/gdb.reverse/aarch64-cssc.c   |  88 +++++++++++++
>>   gdb/testsuite/gdb.reverse/aarch64-cssc.exp | 139 +++++++++++++++++++++
>>   gdb/testsuite/lib/gdb.exp                  |  52 ++++++++
>>   3 files changed, 279 insertions(+)
>>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.c
>>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.exp
> Looks good to me, thanks!
>
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
>
> I think Guinevere should approve it though.
>
Ah! I'm happy to change my review tag to an approval tag, then!

Approved-By: Guinevere Larsen <guinevere@redhat.com>

-- 
Cheers,
Guinevere Larsen
It/she