From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id geMQGHT3FWr5OB4AWB0awg (envelope-from ) for ; Tue, 26 May 2026 15:41:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gJPrT2fn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5ACC31E024; Tue, 26 May 2026 15:41:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 91FD91E024 for ; Tue, 26 May 2026 15:41:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C71D4BA23CB for ; Tue, 26 May 2026 19:41:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C71D4BA23CB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gJPrT2fn Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1DF5D4BA23D2 for ; Tue, 26 May 2026 19:41:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DF5D4BA23D2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DF5D4BA23D2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779824463; cv=none; b=aqM/cxiOM9Tp/sDoIsuIQfuiV9UvzTcEP/74WOy6xnrilll+QKoiJacv9lhmKFZK3K3sHoBsTAV/T3lRM8oN38hcFLDUYKuoDxyY1SLQLdMPM3IgD2OKILLf7PJnvizfnkx5AwBcWmsMILgBe0Hnbn1fxMHkpaV2rX5hNZtT2FU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779824463; c=relaxed/simple; bh=1dn6wNeRZTXXpjcjYA00zxH9krUQO1dA/RiaKf0rO4w=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DshE20Ua1rI+9Upj1P10csIhwN0/3IL+mp0LyXG7p5yPmmDL9PjCTQcdFYlwT+WYjzns/Dn3zDRjuyMAz21huLbAAoWeEJTHhB2vzprFlUxyyrSw46iKfYvmd2zDjLcb9DB1+OOFZLHvC0CBpCzyShABimvepIBhSp2zRUOknH8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gJPrT2fn DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DF5D4BA23D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779824462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sAowi0mZe0s4xmHYUCd5vJXDIqVDhz0A7zdZdjFMHvo=; b=gJPrT2fnIuRQKQ1OD6xgY0BtuT8tBFiIG6XaLdjPZEtUK2pj5bn7OiLLNH9gktVHVaGW9f zIKHvba3OmxDPAMxRw3bt5+PrPEFVOU6EE+ZDhxpLVjS1Iie3A8agqHo3mfmH9Eh3cBEj3 Eyw4F8kfqNzQZQhlzCFeUUGSvly3i2s= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-5dCkMNoIOW6uUet-BVkY9Q-1; Tue, 26 May 2026 15:41:01 -0400 X-MC-Unique: 5dCkMNoIOW6uUet-BVkY9Q-1 X-Mimecast-MFC-AGG-ID: 5dCkMNoIOW6uUet-BVkY9Q_1779824461 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-56fab6d9242so23349281e0c.0 for ; Tue, 26 May 2026 12:41:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779824461; x=1780429261; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sAowi0mZe0s4xmHYUCd5vJXDIqVDhz0A7zdZdjFMHvo=; b=mAsGXudPK3wBfEgsrFzAR7/uq9RNZluU6wwLFDcjQw91egslHyoo5KMiXVUaa6XVqG hJrVLrL8Ugpcub59bQpaLYFxZzNmqB4bknIrg4yX+/86Jj8CeTimIlRCB5sFRr/Pcjnm yqBL0etst4VqnifUS2X4QOCt58giPw97rjfgXEeM78J0qZCpA4Jo2K6KJ699KtYbM4Xa 498wT/HjwalFkt5IYp9h5qVZ2xXXMZj/+LJiBRFXN8Ko9CZpxvuK3GgLgem2xOGirSq7 fGark8i8lAnoSswIC0ge7Vy5TbGxdSg3mCZHQq0intl2sroAlTM6jxMcxBWhWkdy1mW9 g9Iw== X-Gm-Message-State: AOJu0YwuOFQLm6NYORIOPsR8gj5Ny0Mhie1qWFKjC8xRaFAQNUpCXYZ7 K8Z0GsQjRPTgN4YOkBmHnQ6UPRt/DWlXdsawIFjORFlA8Ge+U7BDKiVrjfwUNGUVjI09z9iSud7 H0gELzvlNHi8JmOPUOB77G7p2dhh25CyGS1dDxdvwj0jotowhDMLpthrIVJnlyUY= X-Gm-Gg: Acq92OG4BT8IAWUWSqiZlFBu72zCcLHdRFL4oT/opKsXAQyfAEet9Sz2TtSc6fLLiKL onHzyFR1A/JJKK3KClQmrH0ct19vsNgiyf7lSM4lMF0fUVDvjEdj14sLYoKk17RYL4xXfg3SSiZ Cj9Xg6l4PNcav+WmKpsJqTUl01Wbdehlv9KSYPONa6OJmeoH5fn0zf8DSHFXT2TTr2XVVrWse/z twraZ1YHsOVaXkNtvvNSvzAkdvo0mpyTZIEMpAm6X6W0K8Mpo/SiQaiz7LRPKXM/Hw6ZFDzTnDZ SCyTmn0uISnyWKBo4ntsOEZYCho68nRc5fkEkjoGvLNmGiZkiC6mREEkFfcn7zz2ob7HdeLlcB0 vFdY/UmxEQanP3E8rS7ztR80bVuwBqDuTIt4O+oxAIWrE/ovhr0aR5jpErw4/yLEPUP1D X-Received: by 2002:a05:6122:2203:b0:56e:e80c:bb25 with SMTP id 71dfb90a1353d-586649efacfmr11638922e0c.13.1779824460782; Tue, 26 May 2026 12:41:00 -0700 (PDT) X-Received: by 2002:a05:6122:2203:b0:56e:e80c:bb25 with SMTP id 71dfb90a1353d-586649efacfmr11638911e0c.13.1779824460371; Tue, 26 May 2026 12:41:00 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e:2d5d:7adb:2b6:a50e? ([2804:14d:8084:993e:2d5d:7adb:2b6:a50e]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-586f2f791d1sm17488183e0c.5.2026.05.26.12.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 12:40:58 -0700 (PDT) Message-ID: <3ec42d12-0475-4d37-af9c-bee850070892@redhat.com> Date: Tue, 26 May 2026 16:40:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] gdb/aarch64: Test record/replay support for CSSC To: Thiago Jung Bauermann , Ezra.Sitorus@arm.com Cc: gdb-patches@sourceware.org, luis.machado.foss@gmail.com References: <20260512231707.18123-1-Ezra.Sitorus@arm.com> <20260512231707.18123-3-Ezra.Sitorus@arm.com> <87zf21baal.fsf@linaro.org> From: Guinevere Larsen In-Reply-To: <87zf21baal.fsf@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2qn0Dzw8s8aRXnsZvD7iAgLrDhGHFrMnTWI2N7EkwoQ_1779824461 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/15/26 12:50 AM, Thiago Jung Bauermann wrote: > writes: > >> From: Ezra Sitorus >> >> GDB can handle AArch64's CSSC instructions but there were no tests >> ensuring that and ensuring no regressions would creep in. This commit >> adds some tests for these instructions. This was tested on >> aarch64-none-linux-gnu on QEMU with CSSC support. >> --- >> gdb/testsuite/gdb.reverse/aarch64-cssc.c | 88 +++++++++++++ >> gdb/testsuite/gdb.reverse/aarch64-cssc.exp | 139 +++++++++++++++++++++ >> gdb/testsuite/lib/gdb.exp | 52 ++++++++ >> 3 files changed, 279 insertions(+) >> create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.c >> create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.exp > Looks good to me, thanks! > > Reviewed-by: Thiago Jung Bauermann > > I think Guinevere should approve it though. > Ah! I'm happy to change my review tag to an approval tag, then! Approved-By: Guinevere Larsen -- Cheers, Guinevere Larsen It/she