Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ezra Sitorus <ezra.sitorus@arm.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: <gdb-patches@sourceware.org>, <luis.machado.foss@gmail.com>,
	<thiago.bauermann@linaro.org>
Subject: Re: [PATCH v2 1/4] gdb/aarch64: record/replay support for LRCPC3
Date: Wed, 27 May 2026 00:36:47 +0100	[thread overview]
Message-ID: <ahYujmNxnPNGkE_Z@D2G2X7XGD1> (raw)
In-Reply-To: <f741185a-f505-439f-9951-53c2a4d6003a@redhat.com>

> Hi Ezra! I have one tiny comment with regards to the test (that can
> truthfully probably be ignored), but you shouldn't need to send a v3 just to
> fix that. Feel free to add my review tag
> 
> Reviewed-By: Guinevere Larsen <guinevere@redhat.com

Hi! Thanks all for the reviews - I'll address those comments. One question I
have for GDB workflow: do I explicitly need an Approved-By before I can push?
Or in this case am I waiting on a final approval by Luis or Thiago?

Ezra

  reply	other threads:[~2026-05-26 23:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 23:17 [PATCH v2 0/4] gdb/aarch64: record/replay support for AArch64 Ezra.Sitorus
2026-05-12 23:17 ` [PATCH v2 1/4] gdb/aarch64: record/replay support for LRCPC3 Ezra.Sitorus
2026-05-15  3:50   ` Thiago Jung Bauermann
2026-05-15 11:45     ` Ezra Sitorus
2026-05-15 23:03       ` Thiago Jung Bauermann
2026-05-26 14:30   ` Guinevere Larsen
2026-05-26 23:36     ` Ezra Sitorus [this message]
2026-05-27  0:05       ` Thiago Jung Bauermann
2026-05-12 23:17 ` [PATCH v2 2/4] gdb/aarch64: Test record/replay support for CSSC Ezra.Sitorus
2026-05-15  3:50   ` Thiago Jung Bauermann
2026-05-26 19:40     ` Guinevere Larsen
2026-05-26 16:40   ` Guinevere Larsen
2026-05-12 23:17 ` [PATCH v2 3/4] gdb/aarch64: record/replay support for RPRFM, PRFM (reg), PRFUM Ezra.Sitorus
2026-05-15  3:56   ` Thiago Jung Bauermann
2026-05-12 23:17 ` [PATCH v2 4/4] gdb/aarch64: record/replay support for LSE128 Ezra.Sitorus
2026-05-15  3:58   ` Thiago Jung Bauermann
2026-05-26 19:40   ` Guinevere Larsen
2026-05-15  3:59 ` [PATCH v2 0/4] gdb/aarch64: record/replay support for AArch64 Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahYujmNxnPNGkE_Z@D2G2X7XGD1 \
    --to=ezra.sitorus@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    --cc=luis.machado.foss@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox