Re: [PATCH v3] [gdb/remote] Use sevenbit_strings == true in escape_buffer

[Tom de Vries <tdevries@suse.de>]

On 3/24/26 7:34 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> With Tcl 9.0, something (dejagnu/expect/gdb testsuite infrastructure)
> Tom> has problems with gdb IO containing non-utf-8 chars.
> 
> Tom> Having said that, I don't think having chars like 'ü' in the debug output is
> Tom> particularly helpful.
> 
> Tom> Fix this by forcing sevenbit_strings to true in escape_buffer, getting us
> Tom> instead:
> Tom> ...
> 
> Looks good, thanks.
> 
> Tom> Note that this output is ambiguous, because:
> Tom> - one char '\0', and
> Tom> - 4 chars '\\' '0' '0' '0'
> Tom> are printed the same: \000, but I guess that's a pre-existing problem.
> 
> That's a bit surprising since I would have thought that '\' would also
> be backslash-quoted.
> 

Ok, I double checked this, and you're right, we get \000 vs \\000.

I'll drop that part of the commit message.

Thanks for the review.

- Tom

> Anyway this is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom