Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] [gdb/remote] Use sevenbit_strings == true in escape_buffer
Date: Tue, 24 Mar 2026 12:34:52 -0600	[thread overview]
Message-ID: <87se9p5b5f.fsf@tromey.com> (raw)
In-Reply-To: <20260324153242.916826-1-tdevries@suse.de> (Tom de Vries's message of "Tue, 24 Mar 2026 16:32:42 +0100")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> With Tcl 9.0, something (dejagnu/expect/gdb testsuite infrastructure)
Tom> has problems with gdb IO containing non-utf-8 chars.

Tom> Having said that, I don't think having chars like 'ü' in the debug output is
Tom> particularly helpful.

Tom> Fix this by forcing sevenbit_strings to true in escape_buffer, getting us
Tom> instead:
Tom> ...

Looks good, thanks.

Tom> Note that this output is ambiguous, because:
Tom> - one char '\0', and
Tom> - 4 chars '\\' '0' '0' '0'
Tom> are printed the same: \000, but I guess that's a pre-existing problem.

That's a bit surprising since I would have thought that '\' would also
be backslash-quoted.

Anyway this is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

  reply	other threads:[~2026-03-24 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 15:32 Tom de Vries
2026-03-24 18:34 ` Tom Tromey [this message]
2026-03-24 19:56   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se9p5b5f.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox