From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wtCwJHzswmkG6zcAWB0awg (envelope-from ) for ; Tue, 24 Mar 2026 15:56:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=z0+/si7+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HLyMTVR5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DVyOD94w; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lXP1kAnU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 85AFA1E08C; Tue, 24 Mar 2026 15:56:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 77C161E08C for ; Tue, 24 Mar 2026 15:56:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C66474BB5881 for ; Tue, 24 Mar 2026 19:56:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C66474BB5881 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=z0+/si7+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HLyMTVR5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DVyOD94w; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lXP1kAnU Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id F157E4BB3BC9 for ; Tue, 24 Mar 2026 19:56:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F157E4BB3BC9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F157E4BB3BC9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774382175; cv=none; b=Ws6euuLVrN0ceqIz8OttI0W1e44jPqFqIO5D+o/IqCBZV4y+fjWj5NAmcv0/Iv9O9v9kK7tWE845X8LIdZDhcUiypw2aAz2HVuZK1RDRSTns6NDlMCGjNUlIX7umkD7DQ2u4YradHw+WtwB84Pj1k0ECWJ5fpe/tR2t+L8BZMpE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774382175; c=relaxed/simple; bh=+7kWNmXAZuk03v6LEvuXfuSi7rpV1tYEB1EeH/q20h8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=dJKmYRlM/dH6XE650hiEXC3dxeqh/rq9/pHIIwd8lCcm8I5jjfL1WeGjaHLW2L4gNwYyw5YC3CCsbJJ3ziP2n8pBphnET9PKZK5sRUOKrFxmRw5xqZEPJrKRWOgQojwGZ1BhebViElftCBu0bE2XiPH7Zj4Me9HrDmheTFsdPUI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F157E4BB3BC9 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EF5734D2CE; Tue, 24 Mar 2026 19:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774382174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ppi1Wyu4UiXydkzE0B/CRRx2pb1sVV7OHia+ceAmVnE=; b=z0+/si7+QHiOxK6jlHof2ANw83e557L9VVbpBG9u9dW2dCvvbJzG2ahdrVik5IPXwTqwiQ nE3nugkZhs9TvQ3LwLQatIVIb7B4tztBi1Sjbx9HZ61EIYOd7uXxjAOqct2zCXMQqMlER3 0rS/MPYm7k0qSl2MFrqIKZBoBX8e97o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774382174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ppi1Wyu4UiXydkzE0B/CRRx2pb1sVV7OHia+ceAmVnE=; b=HLyMTVR5w1jJUm6vmxpz5cajqBJmqB5pg/GLB5UCpcftZxg/HV05NygvhuR29Sh1MJYfyf 2ODpgS86etXhL1AA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=DVyOD94w; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lXP1kAnU DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774382173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ppi1Wyu4UiXydkzE0B/CRRx2pb1sVV7OHia+ceAmVnE=; b=DVyOD94waqBaX+6yM9bDyz6MSt/lcSkRyXbFYZObOP4Y2qSvtzFV5FMJiZz05bYJhX5EQt oXcsJPSFp3aEfxFslFYzgQGRDkakYxUwL8qNb6yCgo4X5nMjNr2A7WGlWTkw4nUYzpE0n1 UMnobw243mn1+8doUbCDqEh3o8QGnq0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774382173; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ppi1Wyu4UiXydkzE0B/CRRx2pb1sVV7OHia+ceAmVnE=; b=lXP1kAnUF8JevmToRoM3qLRfuYeGZ6AmjoE3bsqbxfsjQqwbUhQ59irNlWvzQmsYEebQde AG0xbq79mvpA0GDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D670B43FF1; Tue, 24 Mar 2026 19:56:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id RzOYMl3swmngPQAAD6G6ig (envelope-from ); Tue, 24 Mar 2026 19:56:13 +0000 Message-ID: <3c201878-6070-49a2-b237-910cd2b65f2d@suse.de> Date: Tue, 24 Mar 2026 20:56:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] [gdb/remote] Use sevenbit_strings == true in escape_buffer To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260324153242.916826-1-tdevries@suse.de> <87se9p5b5f.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87se9p5b5f.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: EF5734D2CE X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/24/26 7:34 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> With Tcl 9.0, something (dejagnu/expect/gdb testsuite infrastructure) > Tom> has problems with gdb IO containing non-utf-8 chars. > > Tom> Having said that, I don't think having chars like 'ΓΌ' in the debug output is > Tom> particularly helpful. > > Tom> Fix this by forcing sevenbit_strings to true in escape_buffer, getting us > Tom> instead: > Tom> ... > > Looks good, thanks. > > Tom> Note that this output is ambiguous, because: > Tom> - one char '\0', and > Tom> - 4 chars '\\' '0' '0' '0' > Tom> are printed the same: \000, but I guess that's a pre-existing problem. > > That's a bit surprising since I would have thought that '\' would also > be backslash-quoted. > Ok, I double checked this, and you're right, we get \000 vs \\000. I'll drop that part of the commit message. Thanks for the review. - Tom > Anyway this is ok. > Approved-By: Tom Tromey > > Tom