[rfa/x86-64] Supress x86-64 structs.exp test?

[rfa/x86-64] Supress x86-64 structs.exp test?

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

I just ran the new structs.exp on amd64.  Turns out amd digs a hole so 
deep that GDB gets stuck in free fall (an infinite loop resuming the 
target?).  The attached supresses the testfile until someone gets the 
chance to see whats really happening.

thoughts? ok?
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 706 bytes --]

2003-11-20  Andrew Cagney  <cagney@redhat.com>

	* gdb.base/structs.exp: Suppress when "x86_64-*-*".

Index: gdb.base/structs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/structs.exp,v
retrieving revision 1.9
diff -u -r1.9 structs.exp
--- gdb.base/structs.exp	20 Nov 2003 18:03:48 -0000	1.9
+++ gdb.base/structs.exp	20 Nov 2003 18:15:50 -0000
@@ -35,6 +35,13 @@
     continue
 }
 
+# struct return on x86-64 is very broken
+switch -glob -- [istarget] {
+    "x86_64-*-*" {
+	gdb_suppress_entire_file "amd64 is really broken"
+    }
+}
+
 set testfile "structs"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}

Re: [rfa/x86-64] Supress x86-64 structs.exp test?

[Mark Kettenis]

   Date: Thu, 20 Nov 2003 13:23:27 -0500
   From: Andrew Cagney <ac131313@redhat.com>

   I just ran the new structs.exp on amd64.  Turns out amd digs a hole so 
   deep that GDB gets stuck in free fall (an infinite loop resuming the 
   target?).  The attached supresses the testfile until someone gets the 
   chance to see whats really happening.

Hmm, I just get a bunch of internal errors on FreeBSD/amd64.  The
internal errors are caused by some missing check_typedefs.  We could
add some stopgap fixes.  However, AMD64 needs some serious work here.
I intend to convert it to use return_value such that it coreectly
stores return values too.

Meanwhile, I've got no objection If you'd like to check in this patch.
I'll revert it when I've checked in the appropriate fixes.

Mark

   2003-11-20  Andrew Cagney  <cagney@redhat.com>

	   * gdb.base/structs.exp: Suppress when "x86_64-*-*".

Re: [rfa/x86-64] Supress x86-64 structs.exp test?

[Mark Kettenis]

Andrew,

      2003-11-20  Andrew Cagney  <cagney@redhat.com>

	      * gdb.base/structs.exp: Suppress when "x86_64-*-*".

AMD64 is fixed now, so there is no need to check this in anymore.

Mark

Re: [rfa/x86-64] Supress x86-64 structs.exp test?

[Andrew Cagney]

> Andrew,
> 
>       2003-11-20  Andrew Cagney  <cagney@redhat.com>
> 
> 	      * gdb.base/structs.exp: Suppress when "x86_64-*-*".
> 
> AMD64 is fixed now, so there is no need to check this in anymore.

Thanks!  (I was doing a go-slow on committing this since you weren't 
seeing the hangs.)

Andrew