Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com, Roland McGrath <roland@redhat.com>
Subject: Re: [rfa/threads] Convert thread event descriptors to code addrs
Date: Mon, 01 Dec 2003 15:56:00 -0000	[thread overview]
Message-ID: <3FC4E2C6.7060102@redhat.com> (raw)
In-Reply-To: <20031126042653.GA4448@nevyn.them.org>

> On Tue, Nov 25, 2003 at 06:39:42PM -0500, Andrew Cagney wrote:
> 
>> In the light of roland's comments, I've checked in the attached 
>> variation on the original patch.
>> 
>> It still does the conversion but in GDB's libthread_db caller 
>> (enable_thread_event_reporting) and not in libthread_db's symbol lookup 
>> callee (ps_pglobal_lookup).
>> 
>> This way, libthread_db is free to search for either:
>> .__nptl_create_event: the start address
>> __nptl_create_event: the descriptor
>> (the original change would have restricted searches to just the start 
>> address - not a problem now but we never know) and at the same time 
>> ensure that GDB sets breakpoints at the address it needs.
>> 
>> Andrew
> 
> 
>> 2003-11-25  Andrew Cagney  <cagney@redhat.com>
>> 
>> 	* thread-db.c (enable_thread_event): New function.  Ensure that BP
>> 	is a code address.
>> 	(enable_thread_event_reporting): Use enable_thread_event.
> 
> 
> Hmm.  Does this mean remote_lookup_symbol (spelling?) should do the
> same thing?

(remote_check_symbols?)  Wouldn't that be equivalent to my original 
patch (wrong side of libthread_db)?  I suspect you want to add something 
to gdbserver (or just wait for Roland's updated libthread_db).

Andrew



  reply	other threads:[~2003-12-01 15:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-25 21:13 Andrew Cagney
2003-11-25 22:02 ` Michael Snyder
2003-11-25 22:27 ` Roland McGrath
2003-11-25 22:46   ` Andrew Cagney
2003-11-25 23:00     ` Roland McGrath
2003-11-25 23:39       ` Andrew Cagney
2003-11-26  4:26         ` Daniel Jacobowitz
2003-12-01 15:56           ` Andrew Cagney [this message]
2003-12-01 16:01             ` Daniel Jacobowitz
2003-12-03  4:09               ` Andrew Cagney
2003-11-25 23:00     ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FC4E2C6.7060102@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox