From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13195 invoked by alias); 1 Dec 2003 15:56:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13171 invoked from network); 1 Dec 2003 15:56:50 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 1 Dec 2003 15:56:50 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id AD4A12B8F; Wed, 26 Nov 2003 12:28:38 -0500 (EST) Message-ID: <3FC4E2C6.7060102@redhat.com> Date: Mon, 01 Dec 2003 15:56:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com, Roland McGrath Subject: Re: [rfa/threads] Convert thread event descriptors to code addrs References: <200311252300.hAPN016N015872@magilla.sf.frob.com> <3FC3E83E.6090805@redhat.com> <20031126042653.GA4448@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00010.txt.bz2 > On Tue, Nov 25, 2003 at 06:39:42PM -0500, Andrew Cagney wrote: > >> In the light of roland's comments, I've checked in the attached >> variation on the original patch. >> >> It still does the conversion but in GDB's libthread_db caller >> (enable_thread_event_reporting) and not in libthread_db's symbol lookup >> callee (ps_pglobal_lookup). >> >> This way, libthread_db is free to search for either: >> .__nptl_create_event: the start address >> __nptl_create_event: the descriptor >> (the original change would have restricted searches to just the start >> address - not a problem now but we never know) and at the same time >> ensure that GDB sets breakpoints at the address it needs. >> >> Andrew > > >> 2003-11-25 Andrew Cagney >> >> * thread-db.c (enable_thread_event): New function. Ensure that BP >> is a code address. >> (enable_thread_event_reporting): Use enable_thread_event. > > > Hmm. Does this mean remote_lookup_symbol (spelling?) should do the > same thing? (remote_check_symbols?) Wouldn't that be equivalent to my original patch (wrong side of libthread_db)? I suspect you want to add something to gdbserver (or just wait for Roland's updated libthread_db). Andrew