Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/threads] Convert thread event descriptors to code addrs
Date: Tue, 25 Nov 2003 22:46:00 -0000	[thread overview]
Message-ID: <3FC3DBAA.2070605@redhat.com> (raw)
In-Reply-To: <200311252227.hAPMRcmn010069@magilla.sf.frob.com>

Does NPTL do anything with that address internally?  Or just pass it 
through?

> The alternative would be to modify libthread_db so that it knew that 
>> PPC64 symbol were special but I suspect that it doesn't want to know 
>> about such underlying details.
> 
> 
> It seems to me that this is really what ought to change.  ps_pglobal_lookup
> and similar symbols have always had an architecture-neutral interface (with
> the exception of our invention, ps_get_thread_area).  There is no reason
> the implementation of this function by a user of libthread_db should have
> to do anything machine-specific.  gdb already has tons of machine-specific
> knowledge, so it's not really an issue there; but if there are ever simpler
> users of libthread_db, they shouldn't have to worry about this.  It is easy
> enough to change libthread_db to request the symbols it really wants for
> the addresses it needs.  
> 
> Depending how convert_from_func_ptr_addr works, it may well be reasonable
> for gdb to use it as your patch does, to work around the existing buggy
> PPC64 libthread_db implementations.  That is, if that transformation will
> always be a no-op for a real code symbol (i.e. a ".foo" on PPC64), then you
> might as well make gdb seamlessly handle either case.  I'll leave that up
> to you, but do let me know whether you decide to take or leave it, so I
> know how urgent the glibc fix is for gdb users.
> 
> 



  reply	other threads:[~2003-11-25 22:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-25 21:13 Andrew Cagney
2003-11-25 22:02 ` Michael Snyder
2003-11-25 22:27 ` Roland McGrath
2003-11-25 22:46   ` Andrew Cagney [this message]
2003-11-25 23:00     ` Roland McGrath
2003-11-25 23:00     ` Roland McGrath
2003-11-25 23:39       ` Andrew Cagney
2003-11-26  4:26         ` Daniel Jacobowitz
2003-12-01 15:56           ` Andrew Cagney
2003-12-01 16:01             ` Daniel Jacobowitz
2003-12-03  4:09               ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FC3DBAA.2070605@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox