From: Andrew Cagney <cagney@gnu.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] frv-tdep.c: Stop backtraces in entry func, not entry file
Date: Tue, 14 Oct 2003 21:55:00 -0000 [thread overview]
Message-ID: <3F8C70CE.5020504@gnu.org> (raw)
In-Reply-To: <1031014205135.ZM29586@localhost.localdomain>
> An FR-V user reported being unable to see useful backtraces when
> debugging functions inside the entry file. This patch fixes that
> problem. I think there's a problem with inside_entry_func() itself,
> but that's a separate issue. (If you are in the entry file,
> backtraces don't stop at the entry func - they attempt to continue
> beyond, but they do stop shortly thereafter.)
What happens if that test is removed?
I believe the below test has its origins in a d10v hack to get around
what was then a broken back-trace-past-main problem. The problems been
fixed, but unfortunatly, the original hack keeps turning up.
Andrew
> Kevin
>
> * frv-tdep.c (frv_frame_this_id): Call inside_entry_func()
> instead of deprecated_inside_entry_file().
>
> Index: frv-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/frv-tdep.c,v
> retrieving revision 1.54
> diff -u -p -r1.54 frv-tdep.c
> --- frv-tdep.c 14 Oct 2003 00:30:27 -0000 1.54
> +++ frv-tdep.c 14 Oct 2003 20:40:18 -0000
> @@ -1009,7 +1009,7 @@ frv_frame_this_id (struct frame_info *ne
>
> /* This is meant to halt the backtrace at "_start". Make sure we
> don't halt it at a generic dummy frame. */
> - if (deprecated_inside_entry_file (func))
> + if (inside_entry_func (func))
> return;
>
> /* Check if the stack is empty. */
>
next prev parent reply other threads:[~2003-10-14 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-14 20:51 Kevin Buettner
2003-10-14 21:55 ` Andrew Cagney [this message]
2003-10-15 22:39 ` Michael Snyder
2003-10-16 0:07 ` Kevin Buettner
2003-10-16 1:15 ` Andrew Cagney
2003-10-16 3:31 ` Kevin Buettner
2003-10-16 4:10 ` Daniel Jacobowitz
2003-10-20 23:57 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8C70CE.5020504@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox