From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21734 invoked by alias); 14 Oct 2003 21:55:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21722 invoked from network); 14 Oct 2003 21:55:28 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 14 Oct 2003 21:55:28 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 789E02B89; Tue, 14 Oct 2003 17:55:26 -0400 (EDT) Message-ID: <3F8C70CE.5020504@gnu.org> Date: Tue, 14 Oct 2003 21:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] frv-tdep.c: Stop backtraces in entry func, not entry file References: <1031014205135.ZM29586@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00477.txt.bz2 > An FR-V user reported being unable to see useful backtraces when > debugging functions inside the entry file. This patch fixes that > problem. I think there's a problem with inside_entry_func() itself, > but that's a separate issue. (If you are in the entry file, > backtraces don't stop at the entry func - they attempt to continue > beyond, but they do stop shortly thereafter.) What happens if that test is removed? I believe the below test has its origins in a d10v hack to get around what was then a broken back-trace-past-main problem. The problems been fixed, but unfortunatly, the original hack keeps turning up. Andrew > Kevin > > * frv-tdep.c (frv_frame_this_id): Call inside_entry_func() > instead of deprecated_inside_entry_file(). > > Index: frv-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/frv-tdep.c,v > retrieving revision 1.54 > diff -u -p -r1.54 frv-tdep.c > --- frv-tdep.c 14 Oct 2003 00:30:27 -0000 1.54 > +++ frv-tdep.c 14 Oct 2003 20:40:18 -0000 > @@ -1009,7 +1009,7 @@ frv_frame_this_id (struct frame_info *ne > > /* This is meant to halt the backtrace at "_start". Make sure we > don't halt it at a generic dummy frame. */ > - if (deprecated_inside_entry_file (func)) > + if (inside_entry_func (func)) > return; > > /* Check if the stack is empty. */ >