Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Paul Hilfinger <hilfingr@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Changes to allow extensions to operator set
Date: Fri, 05 Sep 2003 15:57:00 -0000	[thread overview]
Message-ID: <3F58B251.7060104@redhat.com> (raw)
In-Reply-To: <20030901093941.0D2E9F2A64@nile.gnat.com>

> 2. Currently, the function dump_prefix_expression is used to dump 
>    postfix expressions and dump_postfix_expression is used to dump
>    prefix expressions.   It is probably a sign of the weakening
>    effects of age on the intellect that I found this confusing, and
>    have renamed dump_prefix_expression to dump_raw_expression (because
>    in principle it doesn't really care whether the expression is 
>    pre- or postfix), and dump_postfix_expression to dump_prefix_expression.
> 
> 3. The current dump_prefix_expression tries to first print the expression 
>    it is dumping with print_expression.  This doesn't work, however,
>    because print_expression operates on prefix expressions, and
>    the current dump_prefix_expression is only used on postfix 
>    expressions.  I simply removed the print_expression.

Bang head against table.  I think it's a sign that the code is rarely 
exercised.  Yes, ok.

Andrew



  parent reply	other threads:[~2003-09-05 15:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-01  9:39 Paul Hilfinger
2003-09-04  2:18 ` Andrew Cagney
2003-09-05  8:32   ` Paul Hilfinger
2003-09-05 15:57 ` Andrew Cagney [this message]
2003-09-05 16:23 ` Andrew Cagney
2003-09-06 11:13   ` Paul Hilfinger
2003-09-11 18:55     ` Andrew Cagney
2003-09-13  8:58       ` Paul Hilfinger
2003-09-18  9:20       ` Paul Hilfinger
2003-09-22 17:04         ` Andrew Cagney
2003-09-05 16:29 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F58B251.7060104@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hilfingr@gnat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox