From: Andrew Cagney <ac131313@redhat.com>
To: Paul Hilfinger <hilfingr@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Changes to allow extensions to operator set
Date: Fri, 05 Sep 2003 16:29:00 -0000 [thread overview]
Message-ID: <3F58B9D3.3020500@redhat.com> (raw)
In-Reply-To: <20030901093941.0D2E9F2A64@nile.gnat.com>
> 1. There was essentially duplicate code in prefixify_subexp and
> length_of_subexp. I have factored out the duplication. [In the
> process, by the way, I happened to notice that BINOP_VAL was
> defined only in length_of_subexp, and indeed that there appears to
> be no code anywhere to handle its evaluation.]
If I understand it correctly, this refactoring (hey I get to use a
buzword) making operator_length global and then calling it from
length_of_subexp is independant of the other stuff, so yes, it can go in.
Nice cleanup.
Andrew
prev parent reply other threads:[~2003-09-05 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-01 9:39 Paul Hilfinger
2003-09-04 2:18 ` Andrew Cagney
2003-09-05 8:32 ` Paul Hilfinger
2003-09-05 15:57 ` Andrew Cagney
2003-09-05 16:23 ` Andrew Cagney
2003-09-06 11:13 ` Paul Hilfinger
2003-09-11 18:55 ` Andrew Cagney
2003-09-13 8:58 ` Paul Hilfinger
2003-09-18 9:20 ` Paul Hilfinger
2003-09-22 17:04 ` Andrew Cagney
2003-09-05 16:29 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F58B9D3.3020500@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=hilfingr@gnat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox