From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29705 invoked by alias); 5 Sep 2003 15:57:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29538 invoked from network); 5 Sep 2003 15:57:11 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 5 Sep 2003 15:57:11 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 36C5E2B7F; Fri, 5 Sep 2003 11:57:05 -0400 (EDT) Message-ID: <3F58B251.7060104@redhat.com> Date: Fri, 05 Sep 2003 15:57:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Paul Hilfinger Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Changes to allow extensions to operator set References: <20030901093941.0D2E9F2A64@nile.gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00069.txt.bz2 > 2. Currently, the function dump_prefix_expression is used to dump > postfix expressions and dump_postfix_expression is used to dump > prefix expressions. It is probably a sign of the weakening > effects of age on the intellect that I found this confusing, and > have renamed dump_prefix_expression to dump_raw_expression (because > in principle it doesn't really care whether the expression is > pre- or postfix), and dump_postfix_expression to dump_prefix_expression. > > 3. The current dump_prefix_expression tries to first print the expression > it is dumping with print_expression. This doesn't work, however, > because print_expression operates on prefix expressions, and > the current dump_prefix_expression is only used on postfix > expressions. I simply removed the print_expression. Bang head against table. I think it's a sign that the code is rarely exercised. Yes, ok. Andrew