From: Andrew Cagney <ac131313@redhat.com>
To: Eli Zaretskii <eliz@elta.co.il>, Corinna Vinschen <vinschen@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] breakpoint.c, scanning epilogue if frame chain is invalid
Date: Thu, 04 Sep 2003 17:21:00 -0000 [thread overview]
Message-ID: <3F57749D.90209@redhat.com> (raw)
In-Reply-To: <2950-Thu04Sep2003195339+0300-eliz@elta.co.il>
>> Date: Wed, 3 Sep 2003 13:18:28 +0200
>> From: Corinna Vinschen <vinschen@redhat.com>
>>
>> if (!within_current_scope || <== fr == NULL
>> fr == get_current_frame ()) <== or fr != NULL and
>> current frame == watchpoint frame
>> then call gdbarch_in_function_epilogue_p(current pc).
>>
>> So after the change gdbarch_in_function_epilogue_p() is also called if the
>> watchpoint frame couldn't be found because the frame chain is temporarily
>> broken. Since this is very likely occuring in an epilogue, it's pretty
>> naturally to call gdbarch_in_function_epilogue_p().
>
>
> Thanks for the explanations, I think this patch is correct.
Corinna, can you add please add comments explaining this as part of the
commit.
Andrew
next prev parent reply other threads:[~2003-09-04 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-03 9:38 Corinna Vinschen
2003-09-03 10:27 ` Eli Zaretskii
2003-09-03 11:18 ` Corinna Vinschen
2003-09-04 17:04 ` Eli Zaretskii
2003-09-04 17:21 ` Andrew Cagney [this message]
2003-09-04 17:33 ` Corinna Vinschen
2003-09-04 17:25 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F57749D.90209@redhat.com \
--to=ac131313@redhat.com \
--cc=eliz@elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox