Re: [RFA] breakpoint.c, scanning epilogue if frame chain is invalid

[Corinna Vinschen <vinschen@redhat.com>]

On Thu, Sep 04, 2003 at 01:21:33PM -0400, Andrew Cagney wrote:
> >>Date: Wed, 3 Sep 2003 13:18:28 +0200
> >>From: Corinna Vinschen <vinschen@redhat.com>
> >>
> >>  if (!within_current_scope ||     <==     fr == NULL
> >>      fr == get_current_frame ())  <==  or fr != NULL and
> >>                                           current frame == watchpoint 
> >>                                           frame
> >>  then call gdbarch_in_function_epilogue_p(current pc).
> >>
> >>So after the change gdbarch_in_function_epilogue_p() is also called if the
> >>watchpoint frame couldn't be found because the frame chain is temporarily
> >>broken.  Since this is very likely occuring in an epilogue, it's pretty
> >>naturally to call gdbarch_in_function_epilogue_p().
> >
> >
> >Thanks for the explanations, I think this patch is correct.
> 
> Corinna, can you add please add comments explaining this as part of the 
> commit.

Yes, I'll do that.  My commit was a bit too hasty anyway.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.