From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12909 invoked by alias); 4 Sep 2003 17:33:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12900 invoked from network); 4 Sep 2003 17:33:35 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 4 Sep 2003 17:33:35 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h84HXXl27302 for ; Thu, 4 Sep 2003 13:33:34 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h84HXWL20381 for ; Thu, 4 Sep 2003 13:33:32 -0400 Received: from cygbert.vinschen.de (vpn50-3.rdu.redhat.com [172.16.50.3]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h84HXVw04688 for ; Thu, 4 Sep 2003 10:33:31 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id 48F5D5804E; Thu, 4 Sep 2003 19:33:29 +0200 (CEST) Date: Thu, 04 Sep 2003 17:33:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] breakpoint.c, scanning epilogue if frame chain is invalid Message-ID: <20030904173329.GJ1859@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20030903093815.GQ1859@cygbert.vinschen.de> <20030903111828.GT1859@cygbert.vinschen.de> <2950-Thu04Sep2003195339+0300-eliz@elta.co.il> <3F57749D.90209@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F57749D.90209@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-09/txt/msg00044.txt.bz2 On Thu, Sep 04, 2003 at 01:21:33PM -0400, Andrew Cagney wrote: > >>Date: Wed, 3 Sep 2003 13:18:28 +0200 > >>From: Corinna Vinschen > >> > >> if (!within_current_scope || <== fr == NULL > >> fr == get_current_frame ()) <== or fr != NULL and > >> current frame == watchpoint > >> frame > >> then call gdbarch_in_function_epilogue_p(current pc). > >> > >>So after the change gdbarch_in_function_epilogue_p() is also called if the > >>watchpoint frame couldn't be found because the frame chain is temporarily > >>broken. Since this is very likely occuring in an epilogue, it's pretty > >>naturally to call gdbarch_in_function_epilogue_p(). > > > > > >Thanks for the explanations, I think this patch is correct. > > Corinna, can you add please add comments explaining this as part of the > commit. Yes, I'll do that. My commit was a bit too hasty anyway. Corinna -- Corinna Vinschen Cygwin Developer Red Hat, Inc.