From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8264 invoked by alias); 4 Sep 2003 17:21:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8253 invoked from network); 4 Sep 2003 17:21:32 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 4 Sep 2003 17:21:32 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6C3772B7F; Thu, 4 Sep 2003 13:21:33 -0400 (EDT) Message-ID: <3F57749D.90209@redhat.com> Date: Thu, 04 Sep 2003 17:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Eli Zaretskii , Corinna Vinschen Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] breakpoint.c, scanning epilogue if frame chain is invalid References: <20030903093815.GQ1859@cygbert.vinschen.de> <20030903111828.GT1859@cygbert.vinschen.de> <2950-Thu04Sep2003195339+0300-eliz@elta.co.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-09/txt/msg00040.txt.bz2 >> Date: Wed, 3 Sep 2003 13:18:28 +0200 >> From: Corinna Vinschen >> >> if (!within_current_scope || <== fr == NULL >> fr == get_current_frame ()) <== or fr != NULL and >> current frame == watchpoint frame >> then call gdbarch_in_function_epilogue_p(current pc). >> >> So after the change gdbarch_in_function_epilogue_p() is also called if the >> watchpoint frame couldn't be found because the frame chain is temporarily >> broken. Since this is very likely occuring in an epilogue, it's pretty >> naturally to call gdbarch_in_function_epilogue_p(). > > > Thanks for the explanations, I think this patch is correct. Corinna, can you add please add comments explaining this as part of the commit. Andrew