Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFC: Some more store.exp failures - tweak the test
Date: Tue, 01 Jul 2003 22:22:00 -0000	[thread overview]
Message-ID: <3F0209A5.9080704@redhat.com> (raw)
In-Reply-To: <20030701215538.GA5542@nevyn.them.org>

> This patch fixes the store.exp failures for ARM.  Two changes:
>   - Change char to signed char, because some patterns match -1.  If anyone
>     prefers changing the patterns to match 255 would work too.

Yes, but use something like `typedef signed char charest' so that the 
function's pattern doesn't need tweaking.

>   - Change "return l" to "return l + r".  "up; print r" doesn't work if
>     "r" is not live across the function call; even without optimization
>     GCC will re-use the register.  Then we lose.

As an aside, isn't that a GCC bug?  If no optimization, shouldn't "r" 
have a single permenant location?  The user's going to expect it to 
work, no matter how dumb their code.

> I believe these changes don't impact the point of the test.  If nobody
> disagrees with me, I'd like to commit this.

Andrew



  reply	other threads:[~2003-07-01 22:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-01 21:55 Daniel Jacobowitz
2003-07-01 22:22 ` Andrew Cagney [this message]
2003-07-01 22:30   ` Daniel Jacobowitz
2003-07-03 13:57   ` Daniel Jacobowitz
2003-07-01 22:19 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F0209A5.9080704@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox