Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: drow@mvista.com, gdb-patches@sources.redhat.com
Subject: Re: RFC: Some more store.exp failures - tweak the test
Date: Tue, 01 Jul 2003 22:19:00 -0000	[thread overview]
Message-ID: <200307012219.h61MJ4W5012351@duracef.shout.net> (raw)

Proofread, not tested.  These changes are okay with me, but I don't want
to go very far in the direction of changing test programs like this.
The 'l + r' thing is innocuous, but the 'signed char' thing bugs me a
little.

drow> I believe these changes don't impact the point of the test.  If nobody
drow> disagrees with me, I'd like to commit this.

Not disagreeing with this case, just advising caution about changes like
this.

Michael C

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2003-07-01  Daniel Jacobowitz  <drow@mvista.com>

	* gdb.base/store.c (wack_char): Make l and r signed characters.
	Return l + r to keep r live across the call.
	(wack_short, wack_int, wack_long, wack_longest, wack_float)
	(wack_double, wack_doublest): Return l + r to keep r live across
	the call.
	* gdb.base/store.exp: Accomodate store.c changes.


             reply	other threads:[~2003-07-01 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-01 22:19 Michael Elizabeth Chastain [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-07-01 21:55 Daniel Jacobowitz
2003-07-01 22:22 ` Andrew Cagney
2003-07-01 22:30   ` Daniel Jacobowitz
2003-07-03 13:57   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307012219.h61MJ4W5012351@duracef.shout.net \
    --to=mec@shout.net \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox