From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4023 invoked by alias); 1 Jul 2003 22:19:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4015 invoked from network); 1 Jul 2003 22:19:06 -0000 Received: from unknown (HELO concert.shout.net) (204.253.184.25) by sources.redhat.com with SMTP; 1 Jul 2003 22:19:06 -0000 Received: from duracef.shout.net (duracef.shout.net [204.253.184.12]) by concert.shout.net (8.12.9/8.12.9) with ESMTP id h61MJ4Mc007121; Tue, 1 Jul 2003 17:19:04 -0500 Received: from duracef.shout.net (localhost [127.0.0.1]) by duracef.shout.net (8.12.9/8.12.9) with ESMTP id h61MJ4ns012352; Tue, 1 Jul 2003 17:19:04 -0500 Received: (from mec@localhost) by duracef.shout.net (8.12.9/8.12.9/Submit) id h61MJ4W5012351; Tue, 1 Jul 2003 18:19:04 -0400 Date: Tue, 01 Jul 2003 22:19:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200307012219.h61MJ4W5012351@duracef.shout.net> To: drow@mvista.com, gdb-patches@sources.redhat.com Subject: Re: RFC: Some more store.exp failures - tweak the test X-SW-Source: 2003-07/txt/msg00020.txt.bz2 Proofread, not tested. These changes are okay with me, but I don't want to go very far in the direction of changing test programs like this. The 'l + r' thing is innocuous, but the 'signed char' thing bugs me a little. drow> I believe these changes don't impact the point of the test. If nobody drow> disagrees with me, I'd like to commit this. Not disagreeing with this case, just advising caution about changes like this. Michael C -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2003-07-01 Daniel Jacobowitz * gdb.base/store.c (wack_char): Make l and r signed characters. Return l + r to keep r live across the call. (wack_short, wack_int, wack_long, wack_longest, wack_float) (wack_double, wack_doublest): Return l + r to keep r live across the call. * gdb.base/store.exp: Accomodate store.c changes.