From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6386 invoked by alias); 1 Jul 2003 22:22:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6378 invoked from network); 1 Jul 2003 22:22:33 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 1 Jul 2003 22:22:33 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0AEBD2B5F; Tue, 1 Jul 2003 18:22:30 -0400 (EDT) Message-ID: <3F0209A5.9080704@redhat.com> Date: Tue, 01 Jul 2003 22:22:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: Some more store.exp failures - tweak the test References: <20030701215538.GA5542@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00021.txt.bz2 > This patch fixes the store.exp failures for ARM. Two changes: > - Change char to signed char, because some patterns match -1. If anyone > prefers changing the patterns to match 255 would work too. Yes, but use something like `typedef signed char charest' so that the function's pattern doesn't need tweaking. > - Change "return l" to "return l + r". "up; print r" doesn't work if > "r" is not live across the function call; even without optimization > GCC will re-use the register. Then we lose. As an aside, isn't that a GCC bug? If no optimization, shouldn't "r" have a single permenant location? The user's going to expect it to work, no matter how dumb their code. > I believe these changes don't impact the point of the test. If nobody > disagrees with me, I'd like to commit this. Andrew