Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch rfc] -Wmissing-prototypes round #3
Date: Fri, 13 Jun 2003 19:40:00 -0000	[thread overview]
Message-ID: <3EEA28B5.2070807@redhat.com> (raw)
In-Reply-To: <200306131413.h5DEDuQ01304@pc960.cambridge.arm.com>

> ac131313@redhat.com said:
>> > 
> 
>> >>	* config/arm/tm-linux.h (arm_linux_svr4_fetch_link_map_offsets):
>> >>	Delete declaration, moved to "arm-tdep.h".  Include "arm-tdep.h".
>> >> 	* arm-tdep.h: Add ARM_TDEP_H wrapper.
>> >> 	(arm_linux_svr4_fetch_link_map_offsets): Declare. 
> 
>> > 
>> > 
>> > arm_linux_svr4_fetch_link_map_offsets should be moved from arm-tdep.c to 
>> > armlinux-tdep.c.  Then it can be made private to that file; it doesn't 
>> > belong in the generic ARM code.
> 
>> 
>> Please be my guest, it will simplify my -Wmissing-prototypes patch.
>> 
> 
> 
> Done.

Thanks, just re-generating a -Wmissing-prototypes build to see what's left.

Andrew



  reply	other threads:[~2003-06-13 19:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-11 17:43 Andrew Cagney
2003-06-11 18:56 ` Mark Kettenis
2003-06-11 19:25   ` Andrew Cagney
2003-06-11 23:47     ` Kevin Buettner
2003-06-11 20:31 ` Kevin Buettner
2003-06-11 20:59   ` Andrew Cagney
2003-06-11 23:30     ` Kevin Buettner
2003-06-12 14:30 ` Richard Earnshaw
2003-06-12 17:09   ` Andrew Cagney
2003-06-13 14:13     ` Richard Earnshaw
2003-06-13 19:40       ` Andrew Cagney [this message]
2003-06-12 18:08 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EEA28B5.2070807@redhat.com \
    --to=ac131313@redhat.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox