From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [patch rfc] -Wmissing-prototypes round #3
Date: Wed, 11 Jun 2003 20:31:00 -0000 [thread overview]
Message-ID: <1030611203142.ZM26545@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "[patch rfc] -Wmissing-prototypes round #3" (Jun 11, 1:42pm)
On Jun 11, 1:42pm, Andrew Cagney wrote:
> This is the next round of fixes for -Wmissing-prototypes. This patch:
>
> - add missing function declarations to CPU-tdep.h
> Ex, the externs in ia64-tdep.c were replaced by declarations in the
> corresponding .h file
[...]
>
> - where needed, create missing CPU-tdep.h files
> Ex: sparc-tdep.h and ia64-aix-tdep.h being created.
> This again ensures that foo.c's function declaration is in foo.h.
Some comments with regard to IA-64:
1) I'd rather have the declarations for
ia64_linux_sigcontext_register_address() and
ia64_aix_sigcontext_register_address() go into a single ia64-tdep.h
file. I think having two files is overkill.
2) However, even that shouldn't be necessary. Now that we have the
OSABI machinery, it should be possible to solve the problem without
having to export these functions at all.
Kevin
next prev parent reply other threads:[~2003-06-11 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 17:43 Andrew Cagney
2003-06-11 18:56 ` Mark Kettenis
2003-06-11 19:25 ` Andrew Cagney
2003-06-11 23:47 ` Kevin Buettner
2003-06-11 20:31 ` Kevin Buettner [this message]
2003-06-11 20:59 ` Andrew Cagney
2003-06-11 23:30 ` Kevin Buettner
2003-06-12 14:30 ` Richard Earnshaw
2003-06-12 17:09 ` Andrew Cagney
2003-06-13 14:13 ` Richard Earnshaw
2003-06-13 19:40 ` Andrew Cagney
2003-06-12 18:08 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030611203142.ZM26545@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox