From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11469 invoked by alias); 11 Jun 2003 20:31:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11396 invoked from network); 11 Jun 2003 20:31:49 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Jun 2003 20:31:49 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h5BKVnH32090 for ; Wed, 11 Jun 2003 16:31:49 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5BKVmI23982; Wed, 11 Jun 2003 16:31:48 -0400 Received: from localhost.localdomain (vpn50-31.rdu.redhat.com [172.16.50.31]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5BKVlE06309; Wed, 11 Jun 2003 16:31:47 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h5BKVgG26546; Wed, 11 Jun 2003 13:31:42 -0700 Date: Wed, 11 Jun 2003 20:31:00 -0000 From: Kevin Buettner Message-Id: <1030611203142.ZM26545@localhost.localdomain> In-Reply-To: Andrew Cagney "[patch rfc] -Wmissing-prototypes round #3" (Jun 11, 1:42pm) References: <3EE76A05.2050409@redhat.com> To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [patch rfc] -Wmissing-prototypes round #3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-06/txt/msg00383.txt.bz2 On Jun 11, 1:42pm, Andrew Cagney wrote: > This is the next round of fixes for -Wmissing-prototypes. This patch: > > - add missing function declarations to CPU-tdep.h > Ex, the externs in ia64-tdep.c were replaced by declarations in the > corresponding .h file [...] > > - where needed, create missing CPU-tdep.h files > Ex: sparc-tdep.h and ia64-aix-tdep.h being created. > This again ensures that foo.c's function declaration is in foo.h. Some comments with regard to IA-64: 1) I'd rather have the declarations for ia64_linux_sigcontext_register_address() and ia64_aix_sigcontext_register_address() go into a single ia64-tdep.h file. I think having two files is overkill. 2) However, even that shouldn't be necessary. Now that we have the OSABI machinery, it should be possible to solve the problem without having to export these functions at all. Kevin